2010-12-09 03:35:46

by Namhyung Kim

Subject: [PATCH] ACPI: fix section mismatch warning

Annotate acpi_os_initialize1() as __init to fix following warning:

LD vmlinux.o
MODPOST vmlinux.o
WARNING: vmlinux.o(.text+0x231587): Section mismatch in reference from the function
acpi_os_initialize1() to the function .init.text:acpi_osi_setup_late()
The function acpi_os_initialize1() references
the function __init acpi_osi_setup_late().
This is often because acpi_os_initialize1 lacks a __init
annotation or the annotation of acpi_osi_setup_late is wrong.

Signed-off-by: Namhyung Kim <[email protected]>
---
drivers/acpi/osl.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
index 966feddf6b1b..f7227e990b0f 100644
--- a/drivers/acpi/osl.c
+++ b/drivers/acpi/osl.c
@@ -1530,7 +1530,7 @@ acpi_status __init acpi_os_initialize(void)
return AE_OK;
}

-acpi_status acpi_os_initialize1(void)
+acpi_status __init acpi_os_initialize1(void)
{
kacpid_wq = create_workqueue("kacpid");
kacpi_notify_wq = create_workqueue("kacpi_notify");
--
1.7.3.3.400.g93cef

2010-12-09 05:04:59

by Zhang, Rui

Subject: Re: [PATCH] ACPI: fix section mismatch warning

On Thu, 2010-12-09 at 11:35 +0800, Namhyung Kim wrote:
> Annotate acpi_os_initialize1() as __init to fix following warning:
>
> LD vmlinux.o
> MODPOST vmlinux.o
> WARNING: vmlinux.o(.text+0x231587): Section mismatch in reference from the function
> acpi_os_initialize1() to the function .init.text:acpi_osi_setup_late()
> The function acpi_os_initialize1() references
> the function __init acpi_osi_setup_late().
> This is often because acpi_os_initialize1 lacks a __init
> annotation or the annotation of acpi_osi_setup_late is wrong.
>
> Signed-off-by: Namhyung Kim <[email protected]>

yes, this is the same patch as
https://patchwork.kernel.org/patch/389432/

thanks,
rui

> ---
> drivers/acpi/osl.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 966feddf6b1b..f7227e990b0f 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1530,7 +1530,7 @@ acpi_status __init acpi_os_initialize(void)
> return AE_OK;
> }
>
> -acpi_status acpi_os_initialize1(void)
> +acpi_status __init acpi_os_initialize1(void)
> {
> kacpid_wq = create_workqueue("kacpid");
> kacpi_notify_wq = create_workqueue("kacpi_notify");