2010-12-13 15:06:57

by Namhyung Kim

Subject: [PATCH] aio: check return value of create_workqueue()

Signed-off-by: Namhyung Kim <[email protected]>
---
fs/aio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/aio.c b/fs/aio.c
index 8c8f6c5b6d79..c56153f5f73e 100644
--- a/fs/aio.c
+++ b/fs/aio.c
@@ -87,7 +87,7 @@ static int __init aio_setup(void)

aio_wq = create_workqueue("aio");
abe_pool = mempool_create_kmalloc_pool(1, sizeof(struct aio_batch_entry));
- BUG_ON(!abe_pool);
+ BUG_ON(!aio_wq || !abe_pool);

pr_debug("aio_setup: sizeof(struct page) = %d\n", (int)sizeof(struct page));

--
1.7.3.3.400.g93cef

2010-12-13 15:58:17

by Jeff Moyer

Subject: Re: [PATCH] aio: check return value of create_workqueue()

Namhyung Kim <[email protected]> writes:

> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> fs/aio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/aio.c b/fs/aio.c
> index 8c8f6c5b6d79..c56153f5f73e 100644
> --- a/fs/aio.c
> +++ b/fs/aio.c
> @@ -87,7 +87,7 @@ static int __init aio_setup(void)
>
> aio_wq = create_workqueue("aio");
> abe_pool = mempool_create_kmalloc_pool(1, sizeof(struct aio_batch_entry));
> - BUG_ON(!abe_pool);
> + BUG_ON(!aio_wq || !abe_pool);
>
> pr_debug("aio_setup: sizeof(struct page) = %d\n", (int)sizeof(struct page));

Acked-by: Jeff Moyer <[email protected]>