2010-12-14 13:33:41

by Toralf Förster

[permalink] [raw]
Subject: [PATCH] checkpatch.pl: fix 2 of 2 errors in ./kernek/panic.c


Signed-off-by: Toralf Förster <[email protected]>
---
kernel/panic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/panic.c b/kernel/panic.c
index 4c13b1a..13623e4 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -56,7 +56,7 @@ EXPORT_SYMBOL(panic_blink);
*
* This function never returns.
*/
-NORET_TYPE void panic(const char * fmt, ...)
+NORET_TYPE void panic(const char *fmt, ...)
{
static char buf[1024];
va_list args;
@@ -75,7 +75,7 @@ NORET_TYPE void panic(const char * fmt, ...)
va_start(args, fmt);
vsnprintf(buf, sizeof(buf), fmt, args);
va_end(args);
- printk(KERN_EMERG "Kernel panic - not syncing: %s\n",buf);
+ printk(KERN_EMERG "Kernel panic - not syncing: %s\n", buf);
#ifdef CONFIG_DEBUG_BUGVERBOSE
dump_stack();
#endif
--
1.7.3.3


2010-12-14 16:17:36

by Thiago Farina

[permalink] [raw]
Subject: Re: [PATCH] checkpatch.pl: fix 2 of 2 errors in ./kernek/panic.c

2010/12/14 Toralf Förster <[email protected]>:
>
> Signed-off-by: Toralf Förster <[email protected]>
> ---
>  kernel/panic.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/panic.c b/kernel/panic.c
> index 4c13b1a..13623e4 100644
> --- a/kernel/panic.c
> +++ b/kernel/panic.c
> @@ -56,7 +56,7 @@ EXPORT_SYMBOL(panic_blink);
>  *
>  *     This function never returns.
>  */
> -NORET_TYPE void panic(const char * fmt, ...)
> +NORET_TYPE void panic(const char *fmt, ...)
>  {
>        static char buf[1024];
>        va_list args;
> @@ -75,7 +75,7 @@ NORET_TYPE void panic(const char * fmt, ...)
>        va_start(args, fmt);
>        vsnprintf(buf, sizeof(buf), fmt, args);
>        va_end(args);
> -       printk(KERN_EMERG "Kernel panic - not syncing: %s\n",buf);
> +       printk(KERN_EMERG "Kernel panic - not syncing: %s\n", buf);
>  #ifdef CONFIG_DEBUG_BUGVERBOSE
>        dump_stack();
>  #endif

Can you put in the change log message the description of those errors
and resend? Looking at this patch it seems they are just whitespace
changes or something very trivial like this.

The subject line could be something more like:
kernek/panic.c: Fix two checkpatch.pl errors: