2010-12-16 15:30:03

by Mark Brown

Subject: [PATCH] regulator: Staticise non-exported functions in mc13892

No point exposing functions that aren't used elsewhere to the global
namespace and sparse warns about doing so.

Signed-off-by: Mark Brown <[email protected]>
---
drivers/regulator/mc13892-regulator.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/mc13892-regulator.c b/drivers/regulator/mc13892-regulator.c
index ca1d30a..16a0532 100644
--- a/drivers/regulator/mc13892-regulator.c
+++ b/drivers/regulator/mc13892-regulator.c
@@ -295,8 +295,8 @@ static struct mc13xxx_regulator mc13892_regulators[] = {
MC13892_GPO_DEFINE(PWGT2SPI, POWERMISC, mc13892_pwgtdrv),
};

-int mc13892_powermisc_rmw(struct mc13xxx_regulator_priv *priv, u32 mask,
- u32 val)
+static int mc13892_powermisc_rmw(struct mc13xxx_regulator_priv *priv, u32 mask,
+ u32 val)
{
struct mc13xxx *mc13892 = priv->mc13xxx;
int ret;
@@ -496,7 +496,7 @@ static int mc13892_vcam_set_mode(struct regulator_dev *rdev, unsigned int mode)
return ret;
}

-unsigned int mc13892_vcam_get_mode(struct regulator_dev *rdev)
+static unsigned int mc13892_vcam_get_mode(struct regulator_dev *rdev)
{
struct mc13xxx_regulator_priv *priv = rdev_get_drvdata(rdev);
int ret, id = rdev_get_id(rdev);
--
1.7.1

2010-12-17 10:42:24

by Liam Girdwood

Subject: Re: [PATCH] regulator: Staticise non-exported functions in mc13892

On Thu, 2010-12-16 at 15:29 +0000, Mark Brown wrote:
> No point exposing functions that aren't used elsewhere to the global
> namespace and sparse warns about doing so.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> drivers/regulator/mc13892-regulator.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)

Applied.

Thanks

Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk