2010-12-16 20:53:09

by Marcelo Roberto Jimenez

Subject: [PATCH] init: Fix for section mismatch in reference from name_to_dev_t().

This patch fixes the following message while compiling the kernel:

WARNING: init/mounts.o(.text+0x40): Section mismatch in reference from
the function name_to_dev_t() to the function
.init.text:devt_from_partuuid()
The function name_to_dev_t() references
the function __init devt_from_partuuid().
This is often because name_to_dev_t lacks a __init
annotation or the annotation of devt_from_partuuid is wrong.

Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
---
init/do_mounts.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/init/do_mounts.c b/init/do_mounts.c
index 830aaec..ba48e11 100644
--- a/init/do_mounts.c
+++ b/init/do_mounts.c
@@ -133,7 +133,7 @@ done:
* bangs.
*/

-dev_t name_to_dev_t(char *name)
+dev_t __init name_to_dev_t(char *name)
{
char s[32];
char *p;
--
1.7.3.2

2010-12-16 22:27:39

by Randy Dunlap

Subject: Re: [PATCH] init: Fix for section mismatch in reference from name_to_dev_t().

On Thu, 16 Dec 2010 18:52:52 -0200 Marcelo Roberto Jimenez wrote:

> This patch fixes the following message while compiling the kernel:

I think that this one is preferable:

https://lkml.org/lkml/2010/12/7/210


> WARNING: init/mounts.o(.text+0x40): Section mismatch in reference from
> the function name_to_dev_t() to the function
> .init.text:devt_from_partuuid()
> The function name_to_dev_t() references
> the function __init devt_from_partuuid().
> This is often because name_to_dev_t lacks a __init
> annotation or the annotation of devt_from_partuuid is wrong.
>
> Signed-off-by: Marcelo Roberto Jimenez <[email protected]>
> ---
> init/do_mounts.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/init/do_mounts.c b/init/do_mounts.c
> index 830aaec..ba48e11 100644
> --- a/init/do_mounts.c
> +++ b/init/do_mounts.c
> @@ -133,7 +133,7 @@ done:
> * bangs.
> */
>
> -dev_t name_to_dev_t(char *name)
> +dev_t __init name_to_dev_t(char *name)
> {
> char s[32];
> char *p;
> --
> 1.7.3.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

2010-12-17 08:04:34

by Marcelo Roberto Jimenez

Subject: Re: [PATCH] init: Fix for section mismatch in reference from name_to_dev_t().

On Thu, Dec 16, 2010 at 20:26, Randy Dunlap <[email protected]> wrote:
>
> On Thu, 16 Dec 2010 18:52:52 -0200 Marcelo Roberto Jimenez wrote:
>
> > This patch fixes the following message while compiling the kernel:
>
> I think that this one is preferable:
>
> https://lkml.org/lkml/2010/12/7/210

I Agree, please do not consider my patch.
Regards,
Marcelo.