If you run checkpatch against multiple patches, and one of them has a
whitespace issue which can be helped via a script (rpt_cleaners), you
will see the same NOTE over and over for all subsequent patches. It
makes it seem like those patches also have whitespace problems when in
reality, there's only one or two bad apples.
So reset rpt_cleaners back to 0 after we've issued the note so that it
only shows up near the patch with the actual problems.
Signed-off-by: Mike Frysinger <[email protected]>
---
Andrew: could you pick this up ? was sent out a few weeks ago ...
scripts/checkpatch.pl | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index e3c7fc0..94aba76 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -2934,6 +2934,7 @@ sub process {
if ($rpt_cleaners) {
print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
print " scripts/cleanfile\n\n";
+ $rpt_cleaners = 0;
}
}
--
1.7.4
On Tue, Feb 1, 2011 at 19:42, Mike Frysinger wrote:
> If you run checkpatch against multiple patches, and one of them has a
> whitespace issue which can be helped via a script (rpt_cleaners), you
> will see the same NOTE over and over for all subsequent patches. It
> makes it seem like those patches also have whitespace problems when in
> reality, there's only one or two bad apples.
>
> So reset rpt_cleaners back to 0 after we've issued the note so that it
> only shows up near the patch with the actual problems.
ping ...
-mike