2011-02-02 02:10:59

by john stultz

[permalink] [raw]
Subject: Re: [PATCH V10 14/15] ptp: Added a clock driver for the IXP46x.

On Thu, 2011-01-27 at 12:00 +0100, Richard Cochran wrote:
> This patch adds a driver for the hardware time stamping unit found on the
> IXP465. The basic clock operations and an external trigger are implemented.
>
> Signed-off-by: Richard Cochran <[email protected]>

Minor nit below, but otherwise,
Acked-by: John Stultz <[email protected]>

> diff --git a/drivers/ptp/ptp_ixp46x.c b/drivers/ptp/ptp_ixp46x.c
> new file mode 100644
> index 0000000..c860030
> --- /dev/null
> +++ b/drivers/ptp/ptp_ixp46x.c
[snip]
> +static int __init ptp_ixp_init(void)
> +{
> + if (!cpu_is_ixp46x())
> + return -ENODEV;
> +
> + ixp_clock.regs =
> + (struct ixp46x_ts_regs __iomem *)IXP4XX_TIMESYNC_BASE_VIRT;

Minor whitespace issue here