2011-02-11 08:49:08

by Axel Lin

Subject: [PATCH] video: s3c-fb: return proper error if clk_get fails

Return PTR_ERR(sfb->bus_clk) instead of 0 if clk_get fails.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/video/s3c-fb.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index 83ce9a0..6817d18 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -1340,6 +1340,7 @@ static int __devinit s3c_fb_probe(struct platform_device *pdev)
sfb->bus_clk = clk_get(dev, "lcd");
if (IS_ERR(sfb->bus_clk)) {
dev_err(dev, "failed to get bus clock\n");
+ ret = PTR_ERR(sfb->bus_clk);
goto err_sfb;
}

--
1.7.2

2011-02-14 00:19:25

by Kyungmin Park

Subject: Re: [PATCH] video: s3c-fb: return proper error if clk_get fails

Acked-by: Kyungmin Park <[email protected]>

On Fri, Feb 11, 2011 at 5:51 PM, Axel Lin <[email protected]> wrote:
> Return PTR_ERR(sfb->bus_clk) instead of 0 if clk_get fails.
>
> Signed-off-by: Axel Lin <[email protected]>
> ---
> ?drivers/video/s3c-fb.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 83ce9a0..6817d18 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -1340,6 +1340,7 @@ static int __devinit s3c_fb_probe(struct platform_device *pdev)
> ? ? ? ?sfb->bus_clk = clk_get(dev, "lcd");
> ? ? ? ?if (IS_ERR(sfb->bus_clk)) {
> ? ? ? ? ? ? ? ?dev_err(dev, "failed to get bus clock\n");
> + ? ? ? ? ? ? ? ret = PTR_ERR(sfb->bus_clk);
> ? ? ? ? ? ? ? ?goto err_sfb;
> ? ? ? ?}
>
> --
> 1.7.2
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at ?http://www.tux.org/lkml/
>