2011-02-22 10:51:34

by Namhyung Kim

Subject: [PATCH] mempolicy: remove redundant check in __mpol_equal()

The 'flags' field is already checked, no need to do it again.

Signed-off-by: Namhyung Kim <[email protected]>
Cc: Bob Liu <[email protected]>
Cc: Lee Schermerhorn <[email protected]>
---
mm/mempolicy.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 368fc9d23610..4244e4988e66 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -1979,8 +1979,7 @@ int __mpol_equal(struct mempolicy *a, struct mempolicy *b)
case MPOL_INTERLEAVE:
return nodes_equal(a->v.nodes, b->v.nodes);
case MPOL_PREFERRED:
- return a->v.preferred_node == b->v.preferred_node &&
- a->flags == b->flags;
+ return a->v.preferred_node == b->v.preferred_node;
default:
BUG();
return 0;
--
1.7.4

2011-02-22 12:21:21

by Minchan Kim

Subject: Re: [PATCH] mempolicy: remove redundant check in __mpol_equal()

On Tue, Feb 22, 2011 at 7:51 PM, Namhyung Kim <[email protected]> wrote:
> The 'flags' field is already checked, no need to do it again.
>
> Signed-off-by: Namhyung Kim <[email protected]>
> Cc: Bob Liu <[email protected]>
> Cc: Lee Schermerhorn <[email protected]>
Reviewed-by: Minchan Kim <[email protected]>

Bob's mempolicy: remove redundant check(1980050250) made it redundant.
Good eye!


--
Kind regards,
Minchan Kim