2011-02-23 13:40:10

by Ike Panhc

Subject: [PATCH] ideapad: read brightness setting on brightness key notify

BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922

On ideapad Y530, the brightness key notify will be blocked if the last notify
is not responsed by getting the brightness value. Read value when we get the
notify shall fix the problem and will not have any difference on other ideapads.

Signed-off-by: Ike Panhc <[email protected]>
---
drivers/platform/x86/ideapad-laptop.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/ideapad-laptop.c b/drivers/platform/x86/ideapad-laptop.c
index 114d952..21b1018 100644
--- a/drivers/platform/x86/ideapad-laptop.c
+++ b/drivers/platform/x86/ideapad-laptop.c
@@ -459,6 +459,8 @@ static void ideapad_acpi_notify(struct acpi_device *adevice, u32 event)
if (test_bit(vpc_bit, &vpc1)) {
if (vpc_bit == 9)
ideapad_sync_rfk_state(adevice);
+ else if (vpc_bit == 4)
+ read_ec_data(handle, 0x12, &vpc2);
else
ideapad_input_report(priv, vpc_bit);
}
--
1.7.4.1

2011-02-23 13:47:53

by Matthew Garrett

Subject: Re: [PATCH] ideapad: read brightness setting on brightness key notify

On Wed, Feb 23, 2011 at 09:39:59PM +0800, Ike Panhc wrote:
> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=25922
>
> On ideapad Y530, the brightness key notify will be blocked if the last notify
> is not responsed by getting the brightness value. Read value when we get the
> notify shall fix the problem and will not have any difference on other ideapads.

Which kernel versions does this hit?

--
Matthew Garrett | [email protected]

2011-02-23 14:07:22

by Ike Panhc

Subject: Re: [PATCH] ideapad: read brightness setting on brightness key notify

On 02/23/2011 09:47 PM, Matthew Garrett wrote:
>
> Which kernel versions does this hit?
>

This patch is made against current checkout of Linus's tree.

2011-02-23 14:22:59

by Matthew Garrett

Subject: Re: [PATCH] ideapad: read brightness setting on brightness key notify

On Wed, Feb 23, 2011 at 10:07:12PM +0800, Ike Panhc wrote:
> On 02/23/2011 09:47 PM, Matthew Garrett wrote:
> >
> > Which kernel versions does this hit?
> >
>
> This patch is made against current checkout of Linus's tree.

The bug, not the patch :)

--
Matthew Garrett | [email protected]

2011-02-23 14:43:18

by Ike Panhc

Subject: Re: [PATCH] ideapad: read brightness setting on brightness key notify

On 02/23/2011 10:22 PM, Matthew Garrett wrote:
> On Wed, Feb 23, 2011 at 10:07:12PM +0800, Ike Panhc wrote:
>> On 02/23/2011 09:47 PM, Matthew Garrett wrote:
>>>
>>> Which kernel versions does this hit?
>>>
>>
>> This patch is made against current checkout of Linus's tree.
>
> The bug, not the patch :)
>

This bug hits .37 and later. But patch is not suitable for .37.y

I will make another patch for stable kernel.

2011-03-11 17:31:32

by Matthew Garrett

Subject: Re: [PATCH] ideapad: read brightness setting on brightness key notify

Applied, thanks.

--
Matthew Garrett | [email protected]