2011-03-05 10:49:04

by Linus Walleij

Subject: [PATCH 3/5] mfd: free dangling irq in ab8500 gpadc probe error path

From: Daniel Willerud <[email protected]>

Signed-off-by: Daniel Willerud <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
---
drivers/mfd/ab8500-gpadc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
index 178cbc5..b5b75b7 100644
--- a/drivers/mfd/ab8500-gpadc.c
+++ b/drivers/mfd/ab8500-gpadc.c
@@ -267,11 +267,13 @@ static int __devinit ab8500_gpadc_probe(struct platform_device *pdev)
if (IS_ERR(gpadc->regu)) {
ret = PTR_ERR(gpadc->regu);
dev_err(gpadc->dev, "failed to get vtvout LDO\n");
- goto fail;
+ goto fail_irq;
}
list_add_tail(&gpadc->node, &ab8500_gpadc_list);
dev_dbg(gpadc->dev, "probe success\n");
return 0;
+fail_irq:
+ free_irq(gpadc->irq, gpadc);
fail:
kfree(gpadc);
gpadc = NULL;
--
1.7.3.2

2011-03-07 09:14:36

by Daniel WILLERUD

Subject: RE: [PATCH 3/5] mfd: free dangling irq in ab8500 gpadc probe error path

Acked-by: Daniel Willerud <[email protected]>

-----Original Message-----
From: Linus WALLEIJ
Sent: den 5 mars 2011 11:46
To: Samuel Ortiz; [email protected]
Cc: Lee Jones; Daniel WILLERUD; Linus Walleij
Subject: [PATCH 3/5] mfd: free dangling irq in ab8500 gpadc probe error path

From: Daniel Willerud <[email protected]>

Signed-off-by: Daniel Willerud <[email protected]>
Signed-off-by: Linus Walleij <[email protected]>
---
drivers/mfd/ab8500-gpadc.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/ab8500-gpadc.c b/drivers/mfd/ab8500-gpadc.c
index 178cbc5..b5b75b7 100644
--- a/drivers/mfd/ab8500-gpadc.c
+++ b/drivers/mfd/ab8500-gpadc.c
@@ -267,11 +267,13 @@ static int __devinit ab8500_gpadc_probe(struct platform_device *pdev)
if (IS_ERR(gpadc->regu)) {
ret = PTR_ERR(gpadc->regu);
dev_err(gpadc->dev, "failed to get vtvout LDO\n");
- goto fail;
+ goto fail_irq;
}
list_add_tail(&gpadc->node, &ab8500_gpadc_list);
dev_dbg(gpadc->dev, "probe success\n");
return 0;
+fail_irq:
+ free_irq(gpadc->irq, gpadc);
fail:
kfree(gpadc);
gpadc = NULL;
--
1.7.3.2