2011-03-09 06:34:47

by Namhyung Kim

Subject: [PATCH] vmalloc: remove confusing comment on vwrite()

KM_USER1 is never used for vwrite() path so the caller
doesn't need to guarantee it is not used. Only the caller
should guarantee is KM_USER0 and it is commented already.

Cc: KAMEZAWA Hiroyuki <[email protected]>
Signed-off-by: Namhyung Kim <[email protected]>
---
mm/vmalloc.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index f9b166732e70..2828b6122bd4 100644
--- a/mm/vmalloc.c
+++ b/mm/vmalloc.c
@@ -1951,8 +1951,6 @@ finished:
* should know vmalloc() area is valid and can use memcpy().
* This is for routines which have to access vmalloc area without
* any informaion, as /dev/kmem.
- *
- * The caller should guarantee KM_USER1 is not used.
*/

long vwrite(char *buf, char *addr, unsigned long count)
--
1.7.4

2011-03-09 06:43:48

by Kamezawa Hiroyuki

Subject: Re: [PATCH] vmalloc: remove confusing comment on vwrite()

On Wed, 9 Mar 2011 15:34:36 +0900
Namhyung Kim <[email protected]> wrote:

> KM_USER1 is never used for vwrite() path so the caller
> doesn't need to guarantee it is not used. Only the caller
> should guarantee is KM_USER0 and it is commented already.
>
> Cc: KAMEZAWA Hiroyuki <[email protected]>
> Signed-off-by: Namhyung Kim <[email protected]>
> ---

Acked-by: KAMEZAWA Hiroyuki <[email protected]>