2017-08-19 17:54:34

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 0/4] constify scsi/tty parisc_device_id

parisc_device_id are not supposed to change at runtime. All functions
working with parisc_device_id provided by <asm/parisc-device.h> work with
const parisc_device_id. So mark the non-const structs as const.

Arvind Yadav (4):
[PATCH 1/4] scsi: lasi700: constify parisc_device_id
[PATCH 2/4] scsi: zalon: constify parisc_device_id
[PATCH 3/4] tty: 8250: constify parisc_device_id
[PATCH 4/4] tty: mux: constify parisc_device_id

drivers/scsi/lasi700.c | 2 +-
drivers/scsi/zalon.c | 2 +-
drivers/tty/serial/8250/8250_gsc.c | 4 ++--
drivers/tty/serial/mux.c | 4 ++--
4 files changed, 6 insertions(+), 6 deletions(-)

--
2.7.4


2017-08-19 17:54:38

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 1/4] scsi: lasi700: constify parisc_device_id

parisc_device_id are not supposed to change at runtime. All functions
working with parisc_device_id provided by <asm/parisc-device.h> work
with const parisc_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/scsi/lasi700.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/lasi700.c b/drivers/scsi/lasi700.c
index 5c4ded9..4e2b0e0 100644
--- a/drivers/scsi/lasi700.c
+++ b/drivers/scsi/lasi700.c
@@ -81,7 +81,7 @@ MODULE_LICENSE("GPL");
#define LASI710_CLOCK 40
#define LASI_SCSI_CORE_OFFSET 0x100

-static struct parisc_device_id lasi700_ids[] = {
+static const struct parisc_device_id lasi700_ids[] = {
LASI700_ID_TABLE,
LASI710_ID_TABLE,
{ 0 }
--
2.7.4

2017-08-19 17:54:42

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 2/4] scsi: zalon: constify parisc_device_id

parisc_device_id are not supposed to change at runtime. All functions
working with parisc_device_id provided by <asm/parisc-device.h> work
with const parisc_device_id. So mark the non-const structs as const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/scsi/zalon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/zalon.c b/drivers/scsi/zalon.c
index b2cf1fa..00c7c28 100644
--- a/drivers/scsi/zalon.c
+++ b/drivers/scsi/zalon.c
@@ -160,7 +160,7 @@ zalon_probe(struct parisc_device *dev)
return error;
}

-static struct parisc_device_id zalon_tbl[] = {
+static const struct parisc_device_id zalon_tbl[] = {
{ HPHW_A_DMA, HVERSION_REV_ANY_ID, HVERSION_ANY_ID, 0x00089 },
{ 0, }
};
--
2.7.4

2017-08-21 20:44:35

by Helge Deller

[permalink] [raw]
Subject: Re: [PATCH 0/4] constify scsi/tty parisc_device_id

On 19.08.2017 19:54, Arvind Yadav wrote:
> parisc_device_id are not supposed to change at runtime. All functions
> working with parisc_device_id provided by <asm/parisc-device.h> work with
> const parisc_device_id. So mark the non-const structs as const.
>
> Arvind Yadav (4):
> [PATCH 1/4] scsi: lasi700: constify parisc_device_id
> [PATCH 2/4] scsi: zalon: constify parisc_device_id
> [PATCH 3/4] tty: 8250: constify parisc_device_id
> [PATCH 4/4] tty: mux: constify parisc_device_id

NAK.
Please don't apply.
I have other patches in my tree which will move those consts
into __init sections instead.

Thanks,
Helge


> drivers/scsi/lasi700.c | 2 +-
> drivers/scsi/zalon.c | 2 +-
> drivers/tty/serial/8250/8250_gsc.c | 4 ++--
> drivers/tty/serial/mux.c | 4 ++--
> 4 files changed, 6 insertions(+), 6 deletions(-)
>