2011-03-14 20:43:14

by Stefan Achatz

Subject: [PATCH] HID: roccat: Corrected mode of sysfs attr 'sensor' from koneplus driver

Mode of sysfs attribute 'sensor' was wrongly set to writeonly.
Corrected this to readwrite.

Signed-off-by: Stefan Achatz <[email protected]>
---
drivers/hid/hid-roccat-koneplus.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/hid/hid-roccat-koneplus.c b/drivers/hid/hid-roccat-koneplus.c
index a8e2117..33eec74 100644
--- a/drivers/hid/hid-roccat-koneplus.c
+++ b/drivers/hid/hid-roccat-koneplus.c
@@ -460,7 +460,7 @@ static struct device_attribute koneplus_attributes[] = {

static struct bin_attribute koneplus_bin_attributes[] = {
{
- .attr = { .name = "sensor", .mode = 0220 },
+ .attr = { .name = "sensor", .mode = 0660 },
.size = sizeof(struct koneplus_sensor),
.read = koneplus_sysfs_read_sensor,
.write = koneplus_sysfs_write_sensor
--
1.7.3.4

2011-03-15 14:42:02

by Jiri Kosina

Subject: Re: [PATCH] HID: roccat: Corrected mode of sysfs attr 'sensor' from koneplus driver

On Mon, 14 Mar 2011, Stefan Achatz wrote:

> Mode of sysfs attribute 'sensor' was wrongly set to writeonly.
> Corrected this to readwrite.
>
> Signed-off-by: Stefan Achatz <[email protected]>
> ---
> drivers/hid/hid-roccat-koneplus.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hid/hid-roccat-koneplus.c b/drivers/hid/hid-roccat-koneplus.c
> index a8e2117..33eec74 100644
> --- a/drivers/hid/hid-roccat-koneplus.c
> +++ b/drivers/hid/hid-roccat-koneplus.c
> @@ -460,7 +460,7 @@ static struct device_attribute koneplus_attributes[] = {
>
> static struct bin_attribute koneplus_bin_attributes[] = {
> {
> - .attr = { .name = "sensor", .mode = 0220 },
> + .attr = { .name = "sensor", .mode = 0660 },
> .size = sizeof(struct koneplus_sensor),
> .read = koneplus_sysfs_read_sensor,
> .write = koneplus_sysfs_write_sensor

Applied.

--
Jiri Kosina
SUSE Labs, Novell Inc.