2011-03-16 06:50:58

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build failure after merge of the final tree (ubi tree related)

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)

Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").

I don't know how to fix this, so I have left it for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/

Attachments:
(No filename) (642.00 B)
 (No filename) (490.00 B)
 Download all attachments

2011-03-16 07:27:09

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the final tree (ubi tree related)

On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote:
> Hi all,
>
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
>
> Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
>
> I don't know how to fix this, so I have left it for today.

Hmm, strange, include <linux/vmalloc.h> should be enough to use
__vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'll
try to look better.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

2011-03-16 10:15:42

by Benjamin Herrenschmidt

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the final tree (ubi tree related)

On Wed, 2011-03-16 at 09:22 +0200, Artem Bityutskiy wrote:
> On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> > drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> > drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
> >
> > Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
> >
> > I don't know how to fix this, so I have left it for today.
>
> Hmm, strange, include <linux/vmalloc.h> should be enough to use
> __vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'll
> try to look better.

Try adding asm/pgtable.h

Cheers,
Ben.

2011-03-16 10:31:27

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the final tree (ubi tree related)

On Wed, 2011-03-16 at 21:15 +1100, Benjamin Herrenschmidt wrote:
> On Wed, 2011-03-16 at 09:22 +0200, Artem Bityutskiy wrote:
> > On Wed, 2011-03-16 at 17:50 +1100, ext Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > >
> > > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> > > drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > > drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> > > drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
> > >
> > > Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
> > >
> > > I don't know how to fix this, so I have left it for today.
> >
> > Hmm, strange, include <linux/vmalloc.h> should be enough to use
> > __vmalloc with 'PAGE_KERNEL' AFAICS, and we have this include... I'll
> > try to look better.
>
> Try adding asm/pgtable.h

Thanks, that's what I was thinking about as well.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

2011-03-16 11:52:32

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: linux-next: build failure after merge of the final tree (ubi tree related)

On Wed, 2011-03-16 at 17:50 +1100, Stephen Rothwell wrote:
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_write':
> drivers/mtd/ubi/io.c:1348: error: 'PAGE_KERNEL' undeclared (first use in this function)
> drivers/mtd/ubi/io.c: In function 'ubi_dbg_check_all_ff':
> drivers/mtd/ubi/io.c:1412: error: 'PAGE_KERNEL' undeclared (first use in this function)
>
> Caused by commit 823ed5091113 ("UBI: allocate write checking buffer on demand").
>
> I don't know how to fix this, so I have left it for today.

Fixed, sorry for the hassle and thank you!

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)