2011-03-21 12:44:12

by Marek Belisko

[permalink] [raw]
Subject: [PATCH 0/2] rtc: sc3: Fix compilation errors.

mini2440_defconfig compilation (possibly also others) are broken
with change : https://lkml.org/lkml/2011/3/15/354

Function s3c_rtc_setpie was remove but not all references
was removed too.

Marek Belisko (2):
rtc: s3c: Fix compilation error in s3c_rtc_release.
rtc: s3c: Fix compilation error in s3c_rtc_remove.

drivers/rtc/rtc-s3c.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)


2011-03-21 12:44:16

by Marek Belisko

[permalink] [raw]
Subject: [PATCH 2/2] rtc: s3c: Fix compilation error in s3c_rtc_remove.

Fix following compilation error:
drivers/rtc/rtc-s3c.c: In function 's3c_rtc_remove':
drivers/rtc/rtc-s3c.c:410:2: error: implicit declaration of function 's3c_rtc_setpie'

Signed-off-by: Marek Belisko <[email protected]>
---
drivers/rtc/rtc-s3c.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 43dcefd..b3466c4 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -407,7 +407,6 @@ static int __devexit s3c_rtc_remove(struct platform_device *dev)
platform_set_drvdata(dev, NULL);
rtc_device_unregister(rtc);

- s3c_rtc_setpie(&dev->dev, 0);
s3c_rtc_setaie(&dev->dev, 0);

clk_disable(rtc_clk);
--
1.7.1

2011-03-21 12:44:14

by Marek Belisko

[permalink] [raw]
Subject: [PATCH 1/2] rtc: s3c: Fix compilation error in s3c_rtc_release.

Fix compilation error:
drivers/rtc/rtc-s3c.c: In function 's3c_rtc_release':
drivers/rtc/rtc-s3c.c:339:2: error: implicit declaration of function 's3c_rtc_setpie'

Signed-off-by: Marek Belisko <[email protected]>
---
drivers/rtc/rtc-s3c.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 7149649..43dcefd 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -336,7 +336,6 @@ static void s3c_rtc_release(struct device *dev)

/* do not clear AIE here, it may be needed for wake */

- s3c_rtc_setpie(dev, 0);
free_irq(s3c_rtc_alarmno, rtc_dev);
free_irq(s3c_rtc_tickno, rtc_dev);
}
--
1.7.1