2011-04-02 06:20:56

by Liu Yuan

Subject: [PATCH] drivers, pch_dma: Fix uninitialized var before use

From: Liu Yuan <[email protected]>

In the function pdc_desc_get(), var 'i' is not
initialized before use. This patch fixes it.

Signed-off-by: Liu Yuan <[email protected]>
---
drivers/dma/pch_dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
index 8d8fef1..6eebc62 100644
--- a/drivers/dma/pch_dma.c
+++ b/drivers/dma/pch_dma.c
@@ -403,7 +403,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
{
struct pch_dma_desc *desc, *_d;
struct pch_dma_desc *ret = NULL;
- int i;
+ int i = 0;

spin_lock(&pd_chan->lock);
list_for_each_entry_safe(desc, _d, &pd_chan->free_list, desc_node) {
--
1.7.1

2011-04-06 09:15:27

by Vinod Koul

Subject: Re: [PATCH] drivers, pch_dma: Fix uninitialized var before use

On Sat, 2011-04-02 at 14:20 +0800, Liu Yuan wrote:
> From: Liu Yuan <[email protected]>
>
> In the function pdc_desc_get(), var 'i' is not
> initialized before use. This patch fixes it.
>
> Signed-off-by: Liu Yuan <[email protected]>
> ---
> drivers/dma/pch_dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index 8d8fef1..6eebc62 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -403,7 +403,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
> {
> struct pch_dma_desc *desc, *_d;
> struct pch_dma_desc *ret = NULL;
> - int i;
> + int i = 0;
>
> spin_lock(&pd_chan->lock);
> list_for_each_entry_safe(desc, _d, &pd_chan->free_list, desc_node) {
Applied, Thanks

--
~Vinod