From: Wanlong Gao <[email protected]>
If it was preempted , and the variable aer_mask_override is
changed after the spin_unlock_irqrestore , it will write an
uninitialized variable by the pci_write_config_dword() function .
Signed-off-by: Wanlong Gao <[email protected]>
---
drivers/pci/pcie/aer/aer_inject.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c
index f62079f..95489cd
--- a/drivers/pci/pcie/aer/aer_inject.c
+++ b/drivers/pci/pcie/aer/aer_inject.c
@@ -326,7 +326,7 @@ static int aer_inject(struct aer_error_inj *einj)
unsigned long flags;
unsigned int devfn = PCI_DEVFN(einj->dev, einj->fn);
int pos_cap_err, rp_pos_cap_err;
- u32 sever, cor_mask, uncor_mask, cor_mask_orig, uncor_mask_orig;
+ u32 sever, cor_mask, uncor_mask, cor_mask_orig = 0, uncor_mask_orig = 0;
int ret = 0;
dev = pci_get_domain_bus_and_slot((int)einj->domain, einj->bus, devfn);
--
1.7.3
On Mon, 4 Apr 2011 17:12:59 +0800
[email protected] wrote:
> From: Wanlong Gao <[email protected]>
>
> If it was preempted , and the variable aer_mask_override is
> changed after the spin_unlock_irqrestore , it will write an
> uninitialized variable by the pci_write_config_dword() function .
Applied to my linux-next branch, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
On 4/13/11, Jesse Barnes <[email protected]> wrote:
> On Mon, 4 Apr 2011 17:12:59 +0800
> [email protected] wrote:
>
>> From: Wanlong Gao <[email protected]>
>>
>> If it was preempted , and the variable aer_mask_override is
>> changed after the spin_unlock_irqrestore , it will write an
>> uninitialized variable by the pci_write_config_dword() function .
>
> Applied to my linux-next branch, thanks.
Thank you for your hard work to the open-source .
Best regards .
>
> --
> Jesse Barnes, Intel Open Source Technology Center
>
--
Best regards
Wanlong Gao