2011-04-04 10:31:03

by Wanlong Gao

Subject: [PATCH] USB:Fix the wrong function prototype .

From: Wanlong Gao <[email protected]>

While the "mct_u232_device.ioctl" initialized by a wrong function
prototype . And the argument "struct file *file" is unused in
the function "mct_u232_ioctl()".

Signed-off-by: Wanlong Gao <[email protected]>
---
drivers/usb/serial/mct_u232.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/usb/serial/mct_u232.c b/drivers/usb/serial/mct_u232.c
index d2c0196..ba0d287
--- a/drivers/usb/serial/mct_u232.c
+++ b/drivers/usb/serial/mct_u232.c
@@ -106,7 +106,7 @@ static void mct_u232_break_ctl(struct tty_struct *tty, int break_state);
static int mct_u232_tiocmget(struct tty_struct *tty);
static int mct_u232_tiocmset(struct tty_struct *tty,
unsigned int set, unsigned int clear);
-static int mct_u232_ioctl(struct tty_struct *tty, struct file *file,
+static int mct_u232_ioctl(struct tty_struct *tty,
unsigned int cmd, unsigned long arg);
static int mct_u232_get_icount(struct tty_struct *tty,
struct serial_icounter_struct *icount);
@@ -874,7 +874,7 @@ static void mct_u232_unthrottle(struct tty_struct *tty)
}
}

-static int mct_u232_ioctl(struct tty_struct *tty, struct file *file,
+static int mct_u232_ioctl(struct tty_struct *tty,
unsigned int cmd, unsigned long arg)
{
DEFINE_WAIT(wait);
--
1.7.3

2011-04-04 10:39:52

by Johan Hovold

Subject: Re: [PATCH] USB:Fix the wrong function prototype .

On Mon, Apr 04, 2011 at 06:29:57PM +0800, [email protected] wrote:
> From: Wanlong Gao <[email protected]>
>
> While the "mct_u232_device.ioctl" initialized by a wrong function
> prototype . And the argument "struct file *file" is unused in
> the function "mct_u232_ioctl()".

Thanks for the patch, but I believe there was patch submitted last
Friday which also fixes this issue:

https://lkml.org/lkml/2011/4/3/74

Thanks,
Johan

2011-04-04 10:45:18

by Wanlong Gao

Subject: Re: Re: [PATCH] USB:Fix the wrong function prototype .

Oh, sorry for the duplication .

Thanks.