2011-04-01 10:25:34

by Axel Lin

Subject: [PATCH] regulator: Fix the argument of calling regulator_mode_constrain

The second parameter of regulator_mode_constrain takes a pointer.

This patch fixes below warning:
drivers/regulator/core.c: In function 'regulator_set_mode':
drivers/regulator/core.c:2014: warning: passing argument 2 of 'regulator_mode_constrain' makes pointer from integer without a cast
drivers/regulator/core.c:200: note: expected 'int *' but argument is of type 'unsigned int'

Signed-off-by: Axel Lin <[email protected]>
---
drivers/regulator/core.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index a634946..fff95c3 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -2011,7 +2011,7 @@ int regulator_set_mode(struct regulator *regulator, unsigned int mode)
}

/* constraints check */
- ret = regulator_mode_constrain(rdev, mode);
+ ret = regulator_mode_constrain(rdev, &mode);
if (ret < 0)
goto out;

--
1.7.1

2011-04-02 01:03:47

by Mark Brown

Subject: Re: [PATCH] regulator: Fix the argument of calling regulator_mode_constrain

On Fri, Apr 01, 2011 at 06:25:25PM +0800, Axel Lin wrote:
> The second parameter of regulator_mode_constrain takes a pointer.
>
> This patch fixes below warning:
> drivers/regulator/core.c: In function 'regulator_set_mode':
> drivers/regulator/core.c:2014: warning: passing argument 2 of 'regulator_mode_constrain' makes pointer from integer without a cast
> drivers/regulator/core.c:200: note: expected 'int *' but argument is of type 'unsigned int'

Acked-by: Mark Brown <[email protected]>

2011-04-05 09:07:29

by Liam Girdwood

Subject: Re: [PATCH] regulator: Fix the argument of calling regulator_mode_constrain

On Fri, 2011-04-01 at 18:25 +0800, Axel Lin wrote:
> The second parameter of regulator_mode_constrain takes a pointer.
>
> This patch fixes below warning:
> drivers/regulator/core.c: In function 'regulator_set_mode':
> drivers/regulator/core.c:2014: warning: passing argument 2 of 'regulator_mode_constrain' makes pointer from integer without a cast
> drivers/regulator/core.c:200: note: expected 'int *' but argument is of type 'unsigned int'
>
> Signed-off-by: Axel Lin <[email protected]>

Applied.

Thanks

Liam