2011-04-05 15:00:41

by Michal Marek

[permalink] [raw]
Subject: [PATCH 33/34] usb/lh7a40x_udc: Drop __DATE__ usage

The kernel already prints its build timestamp during boot, no need to
repeat it in random drivers and produce different object files each
time.

Cc: Marc Singer <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Michal Marek <[email protected]>
---
drivers/usb/gadget/lh7a40x_udc.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/gadget/lh7a40x_udc.c b/drivers/usb/gadget/lh7a40x_udc.c
index 6b58bd8..1e99e03 100644
--- a/drivers/usb/gadget/lh7a40x_udc.c
+++ b/drivers/usb/gadget/lh7a40x_udc.c
@@ -42,7 +42,6 @@
#endif

#define DRIVER_DESC "LH7A40x USB Device Controller"
-#define DRIVER_VERSION __DATE__

#ifndef _BIT /* FIXME - what happended to _BIT in 2.6.7bk18? */
#define _BIT(x) (1<<(x))
@@ -209,10 +208,10 @@ udc_proc_read(char *page, char **start, off_t off, int count,
/* basic device status */
t = scnprintf(next, size,
DRIVER_DESC "\n"
- "%s version: %s\n"
+ "%s\n"
"Gadget driver: %s\n"
"Host: %s\n\n",
- driver_name, DRIVER_VERSION,
+ driver_name,
dev->driver ? dev->driver->driver.name : "(none)",
is_usb_connected()? "full speed" : "disconnected");
size -= t;
@@ -2134,7 +2133,7 @@ static struct platform_driver udc_driver = {

static int __init udc_init(void)
{
- DEBUG("%s: %s version %s\n", __func__, driver_name, DRIVER_VERSION);
+ DEBUG("%s: %s\n", __func__, driver_name);
return platform_driver_register(&udc_driver);
}

--
1.7.4.1


2011-04-05 16:25:26

by Russell King - ARM Linux

[permalink] [raw]
Subject: Re: [PATCH 33/34] usb/lh7a40x_udc: Drop __DATE__ usage

On Tue, Apr 05, 2011 at 04:59:20PM +0200, Michal Marek wrote:
> The kernel already prints its build timestamp during boot, no need to
> repeat it in random drivers and produce different object files each
> time.

This file no longer exists.

2011-04-06 08:23:09

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH 33/34] usb/lh7a40x_udc: Drop __DATE__ usage

On 5.4.2011 18:25, Russell King - ARM Linux wrote:
> On Tue, Apr 05, 2011 at 04:59:20PM +0200, Michal Marek wrote:
>> The kernel already prints its build timestamp during boot, no need to
>> repeat it in random drivers and produce different object files each
>> time.
>
> This file no longer exists.

I only tested the series on top of 2.6.38. I dropped this patch now,
sorry for the noise.

Michal