2011-04-05 15:04:59

by Michal Marek

[permalink] [raw]
Subject: [PATCH 16/34] nand/denali: Drop __TIME__ usage

The kernel already prints its build timestamp during boot, no need to
repeat it in random drivers and produce different object files each
time.

Cc: Chuanxiao Dong <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: [email protected]
Signed-off-by: Michal Marek <[email protected]>
---
drivers/mtd/nand/denali.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index 8c8d3c8..7a3cf8c 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1721,8 +1721,7 @@ static struct pci_driver denali_pci_driver = {

static int __devinit denali_init(void)
{
- printk(KERN_INFO "Spectra MTD driver built on %s @ %s\n",
- __DATE__, __TIME__);
+ printk(KERN_INFO "Spectra MTD driver\n");
return pci_register_driver(&denali_pci_driver);
}

--
1.7.4.1


2011-04-05 15:07:14

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: [PATCH 16/34] nand/denali: Drop __TIME__ usage

On Tue, 2011-04-05 at 16:59 +0200, Michal Marek wrote:
> The kernel already prints its build timestamp during boot, no need to
> repeat it in random drivers and produce different object files each
> time.
>
> Cc: Chuanxiao Dong <[email protected]>
> Cc: David Woodhouse <[email protected]>
> Cc: [email protected]
> Signed-off-by: Michal Marek <[email protected]>

Do you want this to got via the MTD tree or you'd rather merge it with
the rest of the patches via some other tree? In any case,

Acked-by: Artem Bityutskiy <[email protected]>

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)

2011-04-05 15:10:16

by Michal Marek

[permalink] [raw]
Subject: Re: [PATCH 16/34] nand/denali: Drop __TIME__ usage

On 5.4.2011 17:02, Artem Bityutskiy wrote:
> On Tue, 2011-04-05 at 16:59 +0200, Michal Marek wrote:
>> The kernel already prints its build timestamp during boot, no need to
>> repeat it in random drivers and produce different object files each
>> time.
>>
>> Cc: Chuanxiao Dong <[email protected]>
>> Cc: David Woodhouse <[email protected]>
>> Cc: [email protected]
>> Signed-off-by: Michal Marek <[email protected]>
>
> Do you want this to got via the MTD tree or you'd rather merge it with
> the rest of the patches via some other tree? In any case,

The patches do not depend on each other, so they should go via the usual
trees.


> Acked-by: Artem Bityutskiy <[email protected]>

Thanks.
Michal

2011-04-05 15:17:56

by Artem Bityutskiy

[permalink] [raw]
Subject: Re: [PATCH 16/34] nand/denali: Drop __TIME__ usage

On Tue, 2011-04-05 at 16:59 +0200, Michal Marek wrote:
> The kernel already prints its build timestamp during boot, no need to
> repeat it in random drivers and produce different object files each
> time.
>
> Cc: Chuanxiao Dong <[email protected]>
> Cc: David Woodhouse <[email protected]>
> Cc: [email protected]
> Signed-off-by: Michal Marek <[email protected]>
> ---
> drivers/mtd/nand/denali.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)

Pushed to l2-mtd-2.6.git, thanks.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)