2011-04-11 02:41:35

by Peter Pan(潘卫平)

Subject: [PATCH 1/2] gfs:remove a warning in gfs2_lookup_by_inum()

/home/pwp/mysvn/linux/linux-2.6/fs/gfs2/inode.c: In function
‘gfs2_lookup_by_inum’: /home/pwp/mysvn/linux/linux-2.6/fs/gfs2/inode.c:188:16:
warning: ‘inode’ may be used uninitialized in this function

Signed-off-by: Weiping Pan(潘卫平) <[email protected]>
---
fs/gfs2/inode.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
index 97d54a2..5b937c6 100644
--- a/fs/gfs2/inode.c
+++ b/fs/gfs2/inode.c
@@ -185,7 +185,7 @@ struct inode *gfs2_lookup_by_inum(struct gfs2_sbd *sdp, u64 no_addr,
{
struct super_block *sb = sdp->sd_vfs;
struct gfs2_holder i_gh;
- struct inode *inode;
+ struct inode *inode = NULL;
int error;

error = gfs2_glock_nq_num(sdp, no_addr, &gfs2_inode_glops,
--
1.7.4

2011-04-13 10:09:10

by Steven Whitehouse

Subject: Re: [PATCH 1/2] gfs:remove a warning in gfs2_lookup_by_inum()

Hi,

Thanks for the patch, however a fix for this is already in the GFS2 -nmw
git tree,

Steve.

On Mon, 2011-04-11 at 10:42 +0800, Weiping Pan(潘卫平) wrote:
> /home/pwp/mysvn/linux/linux-2.6/fs/gfs2/inode.c: In function
> ‘gfs2_lookup_by_inum’: /home/pwp/mysvn/linux/linux-2.6/fs/gfs2/inode.c:188:16:
> warning: ‘inode’ may be used uninitialized in this function
>
> Signed-off-by: Weiping Pan(潘卫平) <[email protected]>
> ---
> fs/gfs2/inode.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 97d54a2..5b937c6 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -185,7 +185,7 @@ struct inode *gfs2_lookup_by_inum(struct gfs2_sbd *sdp, u64 no_addr,
> {
> struct super_block *sb = sdp->sd_vfs;
> struct gfs2_holder i_gh;
> - struct inode *inode;
> + struct inode *inode = NULL;
> int error;
>
> error = gfs2_glock_nq_num(sdp, no_addr, &gfs2_inode_glops,