2011-04-11 19:54:51

by Andrei Warkentin

Subject: Compile errors for SynthHid

I just tried building linux-next tree and hit a simple compile error.

ToC:
[PATCH] HV SynthHID: Fix compile error.

Thanks,
A

2011-04-11 19:29:51

by Greg KH

Subject: Re: [PATCH] HV SynthHID: Fix compile error.

On Mon, Apr 11, 2011 at 03:01:32PM -0500, Andrei Warkentin wrote:
> Missing include for <asm/delay.h>
>
> Signed-off-by: Andrei Warkentin <[email protected]>
> ---
> drivers/staging/hv/hv_mouse.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
> index 50147f8..c5020c0 100644
> --- a/drivers/staging/hv/hv_mouse.c
> +++ b/drivers/staging/hv/hv_mouse.c
> @@ -23,6 +23,7 @@
> #include <linux/hiddev.h>
> #include <linux/pci.h>
> #include <linux/dmi.h>
> +#include <asm/delay.h>

Never include "<asm/" include files if at all possible.

Anyway, this should already be fixed in Linus's tree, right?

thanks,

greg k-h

2011-04-11 20:06:40

by Andrei Warkentin

Subject: [PATCH] HV SynthHID: Fix compile error.

Missing include for <asm/delay.h>

Signed-off-by: Andrei Warkentin <[email protected]>
---
drivers/staging/hv/hv_mouse.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
index 50147f8..c5020c0 100644
--- a/drivers/staging/hv/hv_mouse.c
+++ b/drivers/staging/hv/hv_mouse.c
@@ -23,6 +23,7 @@
#include <linux/hiddev.h>
#include <linux/pci.h>
#include <linux/dmi.h>
+#include <asm/delay.h>

#include "hv_api.h"
#include "logging.h"
--
1.7.0.4

2011-04-11 20:14:36

by Andrei Warkentin

Subject: Re: [PATCH] HV SynthHID: Fix compile error.

On Mon, Apr 11, 2011 at 2:27 PM, Greg KH <[email protected]> wrote:
> On Mon, Apr 11, 2011 at 03:01:32PM -0500, Andrei Warkentin wrote:
>> Missing include for <asm/delay.h>
>>
>> Signed-off-by: Andrei Warkentin <[email protected]>
>> ---
>> ?drivers/staging/hv/hv_mouse.c | ? ?1 +
>> ?1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
>> index 50147f8..c5020c0 100644
>> --- a/drivers/staging/hv/hv_mouse.c
>> +++ b/drivers/staging/hv/hv_mouse.c
>> @@ -23,6 +23,7 @@
>> ?#include <linux/hiddev.h>
>> ?#include <linux/pci.h>
>> ?#include <linux/dmi.h>
>> +#include <asm/delay.h>
>
> Never include "<asm/" include files if at all possible.
>

Oops, alright, will do.

> Anyway, this should already be fixed in Linus's tree, right?
>

Sorry no clue, if so, thanks ahead. I was testing something else in
SD/MMC-land and wanted to make sure it compiled cleanly on x86/x64.

A