2011-04-11 21:49:15

by Alex Elder

[permalink] [raw]
Subject: [PATCH] xfs_destroy_workqueues() should not be tagged with __exit

Linus, please apply the following patch, which fixes
a problem with ia64 builds that is present in the XFS
pull request I sent you this morning. Thank you.

-Alex

-------- Forwarded Message --------
From: Luck, Tony <[email protected]>
To: [email protected]
Cc: [email protected], [email protected], [email protected]
Subject: [PATCH] xfs_destroy_workqueues() should not be tagged with
__exit
Date: Mon, 11 Apr 2011 12:06:12 -0700

ia64 throws away .exit sections for the built-in CONFIG case, so routines
that are used in other circumstances should not be tagged as __exit.

Signed-off-by: Tony Luck <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>
Signed-off-by: Alex Elder <[email protected]>

---

Should be applied after (or merged into) Dave Chinner's patch
xfs: convert the xfsaild threads to a workqueue
which appeared as commit 0bf6a5bd4b55b466964ead6fa566d8f346a828ee in
next-20110411

diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
index 67d5b2c..b38e58d 100644
--- a/fs/xfs/linux-2.6/xfs_super.c
+++ b/fs/xfs/linux-2.6/xfs_super.c
@@ -1741,7 +1741,7 @@ out:
return -ENOMEM;
}

-STATIC void __exit
+STATIC void
xfs_destroy_workqueues(void)
{
destroy_workqueue(xfs_ail_wq);