2011-04-13 15:00:21

by Liu Yuan

Subject: [PATCH] block, blk-sysfs: Use the variable directly instead of a function call

From: Liu Yuan <[email protected]>

In the function blk_register_queue(), var _dev_ is already assigned by
disk_to_dev().So use it directly instead of calling disk_to_dev() again.

Signed-off-by: Liu Yuan <[email protected]>
---
block/blk-sysfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index 261c75c..cb52393 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -521,7 +521,7 @@ int blk_register_queue(struct gendisk *disk)
if (ret) {
kobject_uevent(&q->kobj, KOBJ_REMOVE);
kobject_del(&q->kobj);
- blk_trace_remove_sysfs(disk_to_dev(disk));
+ blk_trace_remove_sysfs(dev);
kobject_put(&dev->kobj);
return ret;
}
--
1.7.1

2011-04-13 20:13:41

by Jens Axboe

Subject: Re: [PATCH] block, blk-sysfs: Use the variable directly instead of a function call

On 2011-04-13 16:59, Liu Yuan wrote:
> From: Liu Yuan <[email protected]>
>
> In the function blk_register_queue(), var _dev_ is already assigned by
> disk_to_dev().So use it directly instead of calling disk_to_dev() again.

Indeed it is, thanks, I'll add this.

--
Jens Axboe