2011-04-18 21:16:55

by Karthigan Srinivasan

Subject: [PATCH] drivers/base/core.c: Fixed brace coding style issue.

>From 62183d5695ad36b6cef0fbd7617f0060f2dd391d Mon Sep 17 00:00:00 2001
From: Karthigan Srinivasan <[email protected]>
Date: Mon, 18 Apr 2011 16:05:05 -0500
Subject: [PATCH] drivers/base/core.c: Fixed brace coding style issue.

Fixed brace coding style issue.

Signed-off-by: Karthigan Srinivasan <[email protected]>
---
drivers/base/core.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/base/core.c b/drivers/base/core.c
index 81b78ed..f90346e 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -1314,8 +1314,7 @@ EXPORT_SYMBOL_GPL(put_device);
EXPORT_SYMBOL_GPL(device_create_file);
EXPORT_SYMBOL_GPL(device_remove_file);

-struct root_device
-{
+struct root_device {
struct device dev;
struct module *owner;
};
--
1.7.1

2011-04-23 00:06:40

by Greg KH

Subject: Re: [PATCH] drivers/base/core.c: Fixed brace coding style issue.

On Mon, Apr 18, 2011 at 04:16:52PM -0500, Karthigan Srinivasan wrote:
> >From 62183d5695ad36b6cef0fbd7617f0060f2dd391d Mon Sep 17 00:00:00 2001
> From: Karthigan Srinivasan <[email protected]>
> Date: Mon, 18 Apr 2011 16:05:05 -0500
> Subject: [PATCH] drivers/base/core.c: Fixed brace coding style issue.

Why is this in the body of the patch? Please don't do that, it forces
me to edit it by hand. Which is a pain when you have to do it for 900+
patches per release...

So next time, please do this.

thanks,

greg k-h