2011-04-19 11:41:53

by Jonathan Cameron

[permalink] [raw]
Subject: [PATCH 3/3] params.c: Use new strtobool function to process boolean inputs

No functional changes.

Signed-off-by: Jonathan Cameron <[email protected]>
---
kernel/params.c | 14 ++++----------
1 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/kernel/params.c b/kernel/params.c
index 7ab388a..6888761 100644
--- a/kernel/params.c
+++ b/kernel/params.c
@@ -297,21 +297,15 @@ EXPORT_SYMBOL(param_ops_charp);
int param_set_bool(const char *val, const struct kernel_param *kp)
{
bool v;
+ int ret;

/* No equals means "set"... */
if (!val) val = "1";

/* One of =[yYnN01] */
- switch (val[0]) {
- case 'y': case 'Y': case '1':
- v = true;
- break;
- case 'n': case 'N': case '0':
- v = false;
- break;
- default:
- return -EINVAL;
- }
+ ret = strtobool(val, &v);
+ if (ret)
+ return ret;

if (kp->flags & KPARAM_ISBOOL)
*(bool *)kp->arg = v;
--
1.7.3.4