2011-04-22 23:32:35

by J Freyensee

[permalink] [raw]
Subject: [PATCH 1/4] export kernel call get_task_comm().

From: J Freyensee <[email protected]>

This allows drivers who call this function to be compiled modularly.
Otherwise, a driver who is interested in this type of functionality
has to implement their own get_task_comm() call, causing code
duplication in the Linux source tree.

Signed-off-by: J Freyensee <[email protected]>
---
fs/exec.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/fs/exec.c b/fs/exec.c
index 8328beb..e1ac338 100644
--- a/fs/exec.c
+++ b/fs/exec.c
@@ -1004,6 +1004,7 @@ char *get_task_comm(char *buf, struct task_struct *tsk)
task_unlock(tsk);
return buf;
}
+EXPORT_SYMBOL_GPL(get_task_comm);

void set_task_comm(struct task_struct *tsk, char *buf)
{
--
1.7.2.3


2011-04-25 20:57:50

by David Rientjes

[permalink] [raw]
Subject: Re: [PATCH 1/4] export kernel call get_task_comm().

On Fri, 22 Apr 2011, [email protected] wrote:

> From: J Freyensee <[email protected]>
>
> This allows drivers who call this function to be compiled modularly.
> Otherwise, a driver who is interested in this type of functionality
> has to implement their own get_task_comm() call, causing code
> duplication in the Linux source tree.
>
> Signed-off-by: J Freyensee <[email protected]>

Third time:

Acked-by: David Rientjes <[email protected]>

2011-05-05 16:59:39

by J Freyensee

[permalink] [raw]
Subject: Re: [PATCH 1/4] export kernel call get_task_comm().

On Mon, 2011-04-25 at 13:57 -0700, David Rientjes wrote:
> On Fri, 22 Apr 2011, [email protected] wrote:
>
> > From: J Freyensee <[email protected]>
> >
> > This allows drivers who call this function to be compiled modularly.
> > Otherwise, a driver who is interested in this type of functionality
> > has to implement their own get_task_comm() call, causing code
> > duplication in the Linux source tree.
> >
> > Signed-off-by: J Freyensee <[email protected]>
>
> Third time:
>
> Acked-by: David Rientjes <[email protected]>

Okay, so you want me to add an 'acked-by' next time on this patch in my
patch-set series?

2011-05-05 18:55:10

by David Rientjes

[permalink] [raw]
Subject: Re: [PATCH 1/4] export kernel call get_task_comm().

On Thu, 5 May 2011, J Freyensee wrote:

> > Third time:
> >
> > Acked-by: David Rientjes <[email protected]>
>
> Okay, so you want me to add an 'acked-by' next time on this patch in my
> patch-set series?
>

That's the usual convention, yes.