2011-04-23 18:49:40

by Liu Yuan

Subject: [PATCH] drivers, block: virtio_blk: Replace cryptic number with the macro

From: Liu Yuan <[email protected]>

It is easier to figure out the context by reading SCSI_SENSE_BUFFERSIZE
instead of plain '96'.

Signed-off-by: Liu Yuan <[email protected]>
---
drivers/block/virtio_blk.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 6ecf89c..d6a426a 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -6,6 +6,7 @@
#include <linux/virtio.h>
#include <linux/virtio_blk.h>
#include <linux/scatterlist.h>
+#include <scsi/scsi_cmnd.h>

#define PART_BITS 4

@@ -141,7 +142,7 @@ static bool do_req(struct request_queue *q, struct virtio_blk *vblk,
num = blk_rq_map_sg(q, vbr->req, vblk->sg + out);

if (vbr->req->cmd_type == REQ_TYPE_BLOCK_PC) {
- sg_set_buf(&vblk->sg[num + out + in++], vbr->req->sense, 96);
+ sg_set_buf(&vblk->sg[num + out + in++], vbr->req->sense, SCSI_SENSE_BUFFERSIZE);
sg_set_buf(&vblk->sg[num + out + in++], &vbr->in_hdr,
sizeof(vbr->in_hdr));
}
--
1.7.1

2011-04-27 06:07:17

by Rusty Russell

Subject: Re: [PATCH] drivers, block: virtio_blk: Replace cryptic number with the macro

On Sun, 24 Apr 2011 02:49:26 +0800, Liu Yuan <[email protected]> wrote:
> From: Liu Yuan <[email protected]>
>
> It is easier to figure out the context by reading SCSI_SENSE_BUFFERSIZE
> instead of plain '96'.
>
> Signed-off-by: Liu Yuan <[email protected]>

Thanks, applied!

Cheers,
Rusty.