2011-05-06 22:00:21

by Luis R. Rodriguez

Subject: [PATCH] x86: fix mrst sparse complaints

This fixes these few sparse complaints:

CHECK arch/x86/platform/mrst/mrst.c
arch/x86/platform/mrst/mrst.c:197:13: warning: symbol 'mrst_time_init' was not declared. Should it be static?
arch/x86/platform/mrst/mrst.c:219:16: warning: symbol 'mrst_arch_setup' was not declared. Should it be static?
CC arch/x86/platform/mrst/mrst.o

Cc: Roman Gezikov <[email protected]>
Cc: Joonas Viskari <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Cc: Allen Kao <[email protected]>
Cc: "H. Peter Anvin" <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: [email protected]
Signed-off-by: Luis R. Rodriguez <[email protected]>
---
arch/x86/platform/mrst/mrst.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 275dbc1..7000e74 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -194,7 +194,7 @@ static unsigned long __init mrst_calibrate_tsc(void)
return 0;
}

-void __init mrst_time_init(void)
+static void __init mrst_time_init(void)
{
sfi_table_parse(SFI_SIG_MTMR, NULL, NULL, sfi_parse_mtmr);
switch (mrst_timer_options) {
@@ -216,7 +216,7 @@ void __init mrst_time_init(void)
apbt_time_init();
}

-void __cpuinit mrst_arch_setup(void)
+static void __cpuinit mrst_arch_setup(void)
{
if (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x27)
__mrst_cpu_chip = MRST_CPU_CHIP_PENWELL;
--
1.7.4.15.g7811d

2011-05-06 22:30:16

by Alan

Subject: Re: [PATCH] x86: fix mrst sparse complaints

On Fri, 6 May 2011 15:00:09 -0700
"Luis R. Rodriguez" <[email protected]> wrote:

> This fixes these few sparse complaints:
>
> CHECK arch/x86/platform/mrst/mrst.c
> arch/x86/platform/mrst/mrst.c:197:13: warning: symbol 'mrst_time_init' was not declared. Should it be static?
> arch/x86/platform/mrst/mrst.c:219:16: warning: symbol 'mrst_arch_setup' was not declared. Should it be static?
> CC arch/x86/platform/mrst/mrst.o

Please Cc me on Moorestown/Medfield tree stuff. Looks sane enough.

Alan

2011-05-07 09:46:40

by Luis R. Rodriguez

Subject: [tip:x86/cleanups] x86: Fix mrst sparse complaints

Commit-ID: 8fab6af2156c0100f953fd61f4e0b2f82c9776dc
Gitweb: http://git.kernel.org/tip/8fab6af2156c0100f953fd61f4e0b2f82c9776dc
Author: Luis R. Rodriguez <[email protected]>
AuthorDate: Fri, 6 May 2011 15:00:09 -0700
Committer: Ingo Molnar <[email protected]>
CommitDate: Sat, 7 May 2011 10:52:30 +0200

x86: Fix mrst sparse complaints

Fix these Sparse complaints:

CHECK arch/x86/platform/mrst/mrst.c
arch/x86/platform/mrst/mrst.c:197:13: warning: symbol 'mrst_time_init' was not declared. Should it be static?
arch/x86/platform/mrst/mrst.c:219:16: warning: symbol 'mrst_arch_setup' was not declared. Should it be static?

Acked-by: Alan Cox <[email protected]>
Cc: Roman Gezikov <[email protected]>
Cc: Joonas Viskari <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Allen Kao <[email protected]>
Signed-off-by: Luis R. Rodriguez <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
---
arch/x86/platform/mrst/mrst.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c
index 275dbc1..7000e74 100644
--- a/arch/x86/platform/mrst/mrst.c
+++ b/arch/x86/platform/mrst/mrst.c
@@ -194,7 +194,7 @@ static unsigned long __init mrst_calibrate_tsc(void)
return 0;
}

-void __init mrst_time_init(void)
+static void __init mrst_time_init(void)
{
sfi_table_parse(SFI_SIG_MTMR, NULL, NULL, sfi_parse_mtmr);
switch (mrst_timer_options) {
@@ -216,7 +216,7 @@ void __init mrst_time_init(void)
apbt_time_init();
}

-void __cpuinit mrst_arch_setup(void)
+static void __cpuinit mrst_arch_setup(void)
{
if (boot_cpu_data.x86 == 6 && boot_cpu_data.x86_model == 0x27)
__mrst_cpu_chip = MRST_CPU_CHIP_PENWELL;