2011-05-03 12:46:46

by Marek Belisko

Subject: [PATCH] SOC: UDA134x: Remove POWER_OFF_ON_STANDBY define.

Define POWER_OFF_ON_STANDBY cause trobles when trying to get some
sound from codec because code for bias setup was not compiled
(define wasn't defined). This define was removed in commit:
cc3202f5 but again introduced by commit: f0fba2ad1 which then
completely break codec functionality so remove it again.

Signed-off-by: Marek Belisko <[email protected]>
---
sound/soc/codecs/uda134x.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/uda134x.c b/sound/soc/codecs/uda134x.c
index 48ffd40..a7b8f30 100644
--- a/sound/soc/codecs/uda134x.c
+++ b/sound/soc/codecs/uda134x.c
@@ -601,9 +601,7 @@ static struct snd_soc_codec_driver soc_codec_dev_uda134x = {
.reg_cache_step = 1,
.read = uda134x_read_reg_cache,
.write = uda134x_write,
-#ifdef POWER_OFF_ON_STANDBY
.set_bias_level = uda134x_set_bias_level,
-#endif
};

static int __devinit uda134x_codec_probe(struct platform_device *pdev)
--
1.7.4.1

2011-05-08 14:10:27

by Liam Girdwood

Subject: Re: [PATCH] SOC: UDA134x: Remove POWER_OFF_ON_STANDBY define.

On Tue, 2011-05-03 at 14:46 +0200, Marek Belisko wrote:
> Define POWER_OFF_ON_STANDBY cause trobles when trying to get some
> sound from codec because code for bias setup was not compiled
> (define wasn't defined). This define was removed in commit:
> cc3202f5 but again introduced by commit: f0fba2ad1 which then
> completely break codec functionality so remove it again.
>
> Signed-off-by: Marek Belisko <[email protected]>
> ---
> sound/soc/codecs/uda134x.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/codecs/uda134x.c b/sound/soc/codecs/uda134x.c
> index 48ffd40..a7b8f30 100644
> --- a/sound/soc/codecs/uda134x.c
> +++ b/sound/soc/codecs/uda134x.c
> @@ -601,9 +601,7 @@ static struct snd_soc_codec_driver soc_codec_dev_uda134x = {
> .reg_cache_step = 1,
> .read = uda134x_read_reg_cache,
> .write = uda134x_write,
> -#ifdef POWER_OFF_ON_STANDBY
> .set_bias_level = uda134x_set_bias_level,
> -#endif
> };
>
> static int __devinit uda134x_codec_probe(struct platform_device *pdev)

Acked-by: Liam Girdwood <[email protected]>

2011-05-08 14:34:41

by Mark Brown

Subject: Re: [PATCH] SOC: UDA134x: Remove POWER_OFF_ON_STANDBY define.

On Tue, May 03, 2011 at 02:46:32PM +0200, Marek Belisko wrote:
> Define POWER_OFF_ON_STANDBY cause trobles when trying to get some
> sound from codec because code for bias setup was not compiled
> (define wasn't defined). This define was removed in commit:
> cc3202f5 but again introduced by commit: f0fba2ad1 which then
> completely break codec functionality so remove it again.

Applied, thanks.