2011-05-24 18:13:22

by Jonas Gorski

[permalink] [raw]
Subject: [PATCH] exportfs: reallow building as a module

Commit 990d6c2d7aee921e3bce22b2d6a750fd552262be ("vfs: Add name to file
handle conversion support") changed EXPORTFS to be a bool.
This was needed for earlier revisions of the original patch, but the actual
commit put the code needing it into its own file that only gets compiled
when FHANDLE is selected which in turn selects EXPORTFS.
So EXPORTFS can be safely compiled as a module when not selecting FHANDLE.

Signed-off-by: Jonas Gorski <[email protected]>
---
fs/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/Kconfig b/fs/Kconfig
index f3aa9b0..efb7d4e 100644
--- a/fs/Kconfig
+++ b/fs/Kconfig
@@ -47,7 +47,7 @@ config FS_POSIX_ACL
def_bool n

config EXPORTFS
- bool
+ tristate

config FILE_LOCKING
bool "Enable POSIX file locking API" if EXPERT
--
1.7.2.5


2011-05-25 13:22:13

by Aneesh Kumar K.V

[permalink] [raw]
Subject: Re: [PATCH] exportfs: reallow building as a module

On Tue, 24 May 2011 20:12:08 +0200, Jonas Gorski <[email protected]> wrote:
> Commit 990d6c2d7aee921e3bce22b2d6a750fd552262be ("vfs: Add name to file
> handle conversion support") changed EXPORTFS to be a bool.
> This was needed for earlier revisions of the original patch, but the actual
> commit put the code needing it into its own file that only gets compiled
> when FHANDLE is selected which in turn selects EXPORTFS.
> So EXPORTFS can be safely compiled as a module when not selecting FHANDLE.
>
> Signed-off-by: Jonas Gorski <[email protected]>
> ---
> fs/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/Kconfig b/fs/Kconfig
> index f3aa9b0..efb7d4e 100644
> --- a/fs/Kconfig
> +++ b/fs/Kconfig
> @@ -47,7 +47,7 @@ config FS_POSIX_ACL
> def_bool n
>
> config EXPORTFS
> - bool
> + tristate
>
> config FILE_LOCKING
> bool "Enable POSIX file locking API" if EXPERT

Acked-by: Aneesh Kumar K.V <[email protected]>