2011-05-08 09:56:20

by Sven Eckelmann

Subject: [PATCH] checkpatch: add __rcu as a sparse modifier

Signed-off-by: Sven Eckelmann <[email protected]>
---
scripts/checkpatch.pl | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d867081..9dc3800 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -145,7 +145,8 @@ our $Sparse = qr{
__must_check|
__init_refok|
__kprobes|
- __ref
+ __ref|
+ __rcu
}x;

# Notes to $Attribute:
--
1.7.5.1

2011-05-08 18:44:00

by Eric Dumazet

Subject: Re: [PATCH] checkpatch: add __rcu as a sparse modifier

Le dimanche 08 mai 2011 à 11:54 +0200, Sven Eckelmann a écrit :
> Signed-off-by: Sven Eckelmann <[email protected]>
> ---
> scripts/checkpatch.pl | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d867081..9dc3800 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -145,7 +145,8 @@ our $Sparse = qr{
> __must_check|
> __init_refok|
> __kprobes|
> - __ref
> + __ref|
> + __rcu
> }x;
>
> # Notes to $Attribute:

Acked-by: Eric Dumazet <[email protected]>

2011-05-30 08:23:32

by Sven Eckelmann

Subject: [PATCH-resend] checkpatch: add __rcu as a sparse modifier

Fix "need consistent spacing around '*'" error after a __rcu sparse
annotation which was caused by the missing __rcu entry in the
checkpatch.pl internal list of sparse keywords.

Signed-off-by: Sven Eckelmann <[email protected]>
Cc: Andy Whitcroft <[email protected]>
---
I reported that problem 2 1/2 months ago and then send the patch 3 weeks
ago, but never got a reaction. Therefore I resend the patch to Andrew
Morton instead of Andy Whitcroft. He seems to have been responsible for
the last checkpatch.pl-patches.

Btw. thanks Eric Dumazet for the Acked-by.

scripts/checkpatch.pl | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index d867081..9dc3800 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -145,7 +145,8 @@ our $Sparse = qr{
__must_check|
__init_refok|
__kprobes|
- __ref
+ __ref|
+ __rcu
}x;

# Notes to $Attribute:
--
1.7.5.3