2011-05-31 10:32:04

by Tomoya MORINAGA

Subject: [PATCH v4] 8250_pci: add -ENODEV code for Intel EG20T PCH

Intel EG20T PCH has UART device which is compatible with 8250.
Currently, with general configuration, the PCH UART driver is not loaded but
8250 standard driver is loaded.
Therefore, in case of using PCH UART driver, need to disable 8250 pci function.
However, this procedure is not best solution.
This patch, in 8250_pci, if the device is the PCH or the family IOH,
'-ENODEV' is returned.
As a result, disabling 8250-pci processing becomes unnecessary.

Signed-off-by: Tomoya MORINAGA <[email protected]>
---
V4: Rename own_init to return_ENODEV
Add #if defined ~ #endif

V3: add own init() and set the init() to quirk table.

V2: Delete #ifdef CONFIG_SERIAL_PCH_UART ~ #endif
Use quirk table structure
---
drivers/tty/serial/8250_pci.c | 59 +++++++++++++++++++++++++++++++++++++++++
1 files changed, 59 insertions(+), 0 deletions(-)

diff --git a/drivers/tty/serial/8250_pci.c b/drivers/tty/serial/8250_pci.c
index 738cec9..fe8d371 100644
--- a/drivers/tty/serial/8250_pci.c
+++ b/drivers/tty/serial/8250_pci.c
@@ -988,6 +988,15 @@ static int skip_tx_en_setup(struct serial_private *priv,
return pci_default_setup(priv, board, port, idx);
}

+static int return_ENODEV(struct pci_dev *dev)
+{
+#if defined(CONFIG_SERIAL_PCH_UART) || defined(CONFIG_SERIAL_PCH_UART_MODULE)
+ return -ENODEV;
+#else
+ return 0;
+#endif
+}
+
/* This should be in linux/pci_ids.h */
#define PCI_VENDOR_ID_SBSMODULARIO 0x124B
#define PCI_SUBVENDOR_ID_SBSMODULARIO 0x124B
@@ -1430,6 +1439,56 @@ static struct pci_serial_quirk pci_serial_quirks[] __refdata = {
.init = pci_oxsemi_tornado_init,
.setup = pci_default_setup,
},
+ {
+ .vendor = PCI_VENDOR_ID_INTEL,
+ .device = 0x8811,
+ .init = return_ENODEV,
+ },
+ {
+ .vendor = PCI_VENDOR_ID_INTEL,
+ .device = 0x8812,
+ .init = return_ENODEV,
+ },
+ {
+ .vendor = PCI_VENDOR_ID_INTEL,
+ .device = 0x8813,
+ .init = return_ENODEV,
+ },
+ {
+ .vendor = PCI_VENDOR_ID_INTEL,
+ .device = 0x8814,
+ .init = return_ENODEV,
+ },
+ {
+ .vendor = 0x10DB,
+ .device = 0x8027,
+ .init = return_ENODEV,
+ },
+ {
+ .vendor = 0x10DB,
+ .device = 0x8028,
+ .init = return_ENODEV,
+ },
+ {
+ .vendor = 0x10DB,
+ .device = 0x8029,
+ .init = return_ENODEV,
+ },
+ {
+ .vendor = 0x10DB,
+ .device = 0x800C,
+ .init = return_ENODEV,
+ },
+ {
+ .vendor = 0x10DB,
+ .device = 0x800D,
+ .init = return_ENODEV,
+ },
+ {
+ .vendor = 0x10DB,
+ .device = 0x800D,
+ .init = return_ENODEV,
+ },
/*
* Default "match everything" terminator entry
*/
--
1.7.4

2011-05-31 10:47:05

by Michał Mirosław

Subject: Re: [PATCH v4] 8250_pci: add -ENODEV code for Intel EG20T PCH

On Tue, May 31, 2011 at 07:35:30PM +0900, Tomoya MORINAGA wrote:
> Intel EG20T PCH has UART device which is compatible with 8250.
> Currently, with general configuration, the PCH UART driver is not loaded but
> 8250 standard driver is loaded.
> Therefore, in case of using PCH UART driver, need to disable 8250 pci function.
> However, this procedure is not best solution.
> This patch, in 8250_pci, if the device is the PCH or the family IOH,
> '-ENODEV' is returned.
> As a result, disabling 8250-pci processing becomes unnecessary.
[...]

My comment about return_ENODEV() name does not make sense if you put the
ifdef inside that function. I thought you would put it around the device-id
entries.

Best Regards,
Micha? Miros?aw