2011-06-02 05:09:35

by Eric Miao

[permalink] [raw]

Subject: [PATCH] leds: fix the menuconfig being wrongly displayed

---

From: Eric Miao <[email protected]>

Seems when a config option does not have a dependency of the menuconfig,
it messes the display of the rest configs, even if it's a hidden one.

Signed-off-by: Eric Miao <[email protected]>
Cc: Richard Purdie <[email protected]>
---
drivers/leds/Kconfig | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 23f0d5e..7066820 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -7,6 +7,8 @@ menuconfig NEW_LEDS
This is not related to standard keyboard LEDs which are controlled
via the input system.

+if NEW_LEDS
+
config LEDS_CLASS
bool "LED Class Support"
depends on NEW_LEDS
@@ -21,8 +23,6 @@ config LEDS_GPIO_REGISTER
As this function is used by arch code it must not be compiled as a
module.

-if NEW_LEDS
-
comment "LED drivers"

config LEDS_88PM860X
--
1.7.4.1

2011-06-02 12:57:26

by Valdis Klētnieks

[permalink] [raw]

Subject: Re: [PATCH] leds: fix the menuconfig being wrongly displayed

---

On Thu, 02 Jun 2011 13:09:14 +0800, Eric Miao said:
> From: Eric Miao <[email protected]>
>
> Seems when a config option does not have a dependency of the menuconfig,
> it messes the display of the rest configs, even if it's a hidden one.
>
> Signed-off-by: Eric Miao <[email protected]>
> Cc: Richard Purdie <[email protected]>
> ---
> drivers/leds/Kconfig | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
> index 23f0d5e..7066820 100644
> --- a/drivers/leds/Kconfig
> +++ b/drivers/leds/Kconfig
> @@ -7,6 +7,8 @@ menuconfig NEW_LEDS
> This is not related to standard keyboard LEDs which are controlled
> via the input system.
>
> +if NEW_LEDS
> +
> config LEDS_CLASS
> bool "LED Class Support"
> depends on NEW_LEDS

Having added that 'if', do we still need that 'depends'?

---

Attachments:

(No filename) (227.00 B)

2011-06-02 16:11:30

by Eric Miao

[permalink] [raw]

Subject: Re: [PATCH] leds: fix the menuconfig being wrongly displayed

---

On Thu, Jun 2, 2011 at 8:57 PM, <[email protected]> wrote:
> On Thu, 02 Jun 2011 13:09:14 +0800, Eric Miao said:
>> From: Eric Miao <[email protected]>
>>
>> Seems when a config option does not have a dependency of the menuconfig,
>> it messes the display of the rest configs, even if it's a hidden one.
>>
>> Signed-off-by: Eric Miao <[email protected]>
>> Cc: Richard Purdie <[email protected]>
>> ---
>>  drivers/leds/Kconfig |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
>> index 23f0d5e..7066820 100644
>> --- a/drivers/leds/Kconfig
>> +++ b/drivers/leds/Kconfig
>> @@ -7,6 +7,8 @@ menuconfig NEW_LEDS
>>         This is not related to standard keyboard LEDs which are controlled
>>         via the input system.
>>
>> +if NEW_LEDS
>> +
>>  config LEDS_CLASS
>>       bool "LED Class Support"
>>       depends on NEW_LEDS
>
> Having added that 'if', do we still need that 'depends'?
>

I don't think so. We can definitely remove it. Updated as follows:

diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig
index 23f0d5e..1251e6a 100644
--- a/drivers/leds/Kconfig
+++ b/drivers/leds/Kconfig
@@ -7,9 +7,10 @@ menuconfig NEW_LEDS
This is not related to standard keyboard LEDs which are controlled
via the input system.

+if NEW_LEDS
+
config LEDS_CLASS
bool "LED Class Support"
- depends on NEW_LEDS
help
This option enables the led sysfs class in /sys/class/leds. You'll
need this to do anything useful with LEDs. If unsure, say N.
@@ -21,8 +22,6 @@ config LEDS_GPIO_REGISTER
As this function is used by arch code it must not be compiled as a
module.

-if NEW_LEDS
-
comment "LED drivers"

config LEDS_88PM860X