2011-06-03 01:12:28

by Axel Lin

Subject: [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release()

The implementation of nand_release() already call mtd_device_unregister(),
no need to call it again.

Signed-off-by: Axel Lin <[email protected]>
---
drivers/mtd/nand/denali.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index d527621..e119748 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1676,7 +1676,6 @@ static void denali_pci_remove(struct pci_dev *dev)
struct denali_nand_info *denali = pci_get_drvdata(dev);

nand_release(&denali->mtd);
- mtd_device_unregister(&denali->mtd);

denali_irq_cleanup(dev->irq, denali);

--
1.7.4.1

2011-06-03 09:21:09

by Jamie Iles

Subject: Re: [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release()

On Fri, Jun 03, 2011 at 09:12:15AM +0800, Axel Lin wrote:
> The implementation of nand_release() already call mtd_device_unregister(),
> no need to call it again.

Good catch!

> Signed-off-by: Axel Lin <[email protected]>

Acked-by: Jamie Iles <[email protected]>

2011-06-06 10:11:33

by Artem Bityutskiy

Subject: Re: [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release()

On Fri, 2011-06-03 at 09:12 +0800, Axel Lin wrote:
> The implementation of nand_release() already call mtd_device_unregister(),
> no need to call it again.
>
> Signed-off-by: Axel Lin <[email protected]>

Pushed to l2-mtd-2.6.git, thanks.

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)