2011-06-03 06:10:30

by Axel Lin

Subject: [PATCH] mtd: mtdblock: Use DEFINE_MUTEX() for mtdblks_lock

mtdblks_lock can be initialized automatically with
DEFINE_MUTEX() rather than explicitly calling mutex_init().

Signed-off-by: Axel Lin <[email protected]>
---
drivers/mtd/mtdblock.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
index 3326615..1976b6c 100644
--- a/drivers/mtd/mtdblock.c
+++ b/drivers/mtd/mtdblock.c
@@ -44,7 +44,7 @@ struct mtdblk_dev {
enum { STATE_EMPTY, STATE_CLEAN, STATE_DIRTY } cache_state;
};

-static struct mutex mtdblks_lock;
+static DEFINE_MUTEX(mtdblks_lock);

/*
* Cache stuff...
@@ -389,8 +389,6 @@ static struct mtd_blktrans_ops mtdblock_tr = {

static int __init init_mtdblock(void)
{
- mutex_init(&mtdblks_lock);
-
return register_mtd_blktrans(&mtdblock_tr);
}

--
1.7.4.1

2011-06-06 10:24:30

by Artem Bityutskiy

Subject: Re: [PATCH] mtd: mtdblock: Use DEFINE_MUTEX() for mtdblks_lock

On Fri, 2011-06-03 at 14:10 +0800, Axel Lin wrote:
> mtdblks_lock can be initialized automatically with
> DEFINE_MUTEX() rather than explicitly calling mutex_init().
>
> Signed-off-by: Axel Lin <[email protected]>

Pushed to l2-mtd-2.6.git, thanks!

--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)