2011-06-10 22:15:44

by Hartley Sweeten

Subject: [PATCH] dma/ep93xx_dma.c: local symbols should be static

The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver
and should be marked static.

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: Mika Westerberg <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: Vinod Koul <[email protected]>

---

diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index 0766c1e..5d7a49b 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
*
* Returns a valid DMA descriptor or %NULL in case of failure.
*/
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
dma_addr_t src, size_t len, unsigned long flags)
{

2011-06-11 05:50:26

by Mika Westerberg

Subject: Re: [PATCH] dma/ep93xx_dma.c: local symbols should be static

On Fri, Jun 10, 2011 at 03:15:05PM -0700, H Hartley Sweeten wrote:
> The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver
> and should be marked static.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>

Acked-by: Mika Westerberg <[email protected]>

> Cc: Dan Williams <[email protected]>
> Cc: Vinod Koul <[email protected]>
>
> ---
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index 0766c1e..5d7a49b 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
> *
> * Returns a valid DMA descriptor or %NULL in case of failure.
> */
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
> ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
> dma_addr_t src, size_t len, unsigned long flags)
> {

2011-06-16 04:56:52

by Vinod Koul

Subject: Re: [PATCH] dma/ep93xx_dma.c: local symbols should be static

On Fri, 2011-06-10 at 15:15 -0700, H Hartley Sweeten wrote:
> The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver
> and should be marked static.
>
> Signed-off-by: H Hartley Sweeten <[email protected]>
> Cc: Mika Westerberg <[email protected]>
> Cc: Dan Williams <[email protected]>
> Cc: Vinod Koul <[email protected]>

Applied Thanks
>
> ---
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index 0766c1e..5d7a49b 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
> *
> * Returns a valid DMA descriptor or %NULL in case of failure.
> */
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
> ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
> dma_addr_t src, size_t len, unsigned long flags)
> {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/


--
~Vinod