2011-06-17 08:10:26

by Axel Lin

Subject: [PATCH 1/2] mtd: onenand/omap2.c: fix build error

Fix below build error:
CC drivers/mtd/onenand/omap2.o
drivers/mtd/onenand/omap2.c: In function 'omap2_onenand_probe':
drivers/mtd/onenand/omap2.c:754: error: 'info' undeclared (first use in this function)
drivers/mtd/onenand/omap2.c:754: error: (Each undeclared identifier is reported only once
drivers/mtd/onenand/omap2.c:754: error: for each function it appears in.)
make[3]: *** [drivers/mtd/onenand/omap2.o] Error 1
make[2]: *** [drivers/mtd/onenand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <[email protected]>
---
drivers/mtd/onenand/omap2.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c
index eb9cbd9..06efa14 100644
--- a/drivers/mtd/onenand/omap2.c
+++ b/drivers/mtd/onenand/omap2.c
@@ -751,7 +751,7 @@ static int __devinit omap2_onenand_probe(struct platform_device *pdev)
if ((r = onenand_scan(&c->mtd, 1)) < 0)
goto err_release_regulator;

- r = mtd_device_parse_register(&info->mtd, NULL, 0,
+ r = mtd_device_parse_register(&c->mtd, NULL, 0,
pdata ? pdata->parts : NULL,
pdata ? pdata->nr_parts : 0);
if (r)
--
1.7.4.1

2011-06-17 08:11:43

by Axel Lin

Subject: [PATCH 2/2] mtd: onenand/samsung.c: fix build error

Fix below build error:
CC drivers/mtd/onenand/samsung.o
drivers/mtd/onenand/samsung.c: In function 's3c_onenand_probe':
drivers/mtd/onenand/samsung.c:1017: error: 'info' undeclared (first use in this function)
drivers/mtd/onenand/samsung.c:1017: error: (Each undeclared identifier is reported only once
drivers/mtd/onenand/samsung.c:1017: error: for each function it appears in.)
make[3]: *** [drivers/mtd/onenand/samsung.o] Error 1
make[2]: *** [drivers/mtd/onenand] Error 2
make[1]: *** [drivers/mtd] Error 2
make: *** [drivers] Error 2

Signed-off-by: Axel Lin <[email protected]>
---
drivers/mtd/onenand/samsung.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mtd/onenand/samsung.c b/drivers/mtd/onenand/samsung.c
index 597dffc..d324074 100644
--- a/drivers/mtd/onenand/samsung.c
+++ b/drivers/mtd/onenand/samsung.c
@@ -1014,7 +1014,7 @@ static int s3c_onenand_probe(struct platform_device *pdev)
if (s3c_read_reg(MEM_CFG_OFFSET) & ONENAND_SYS_CFG1_SYNC_READ)
dev_info(&onenand->pdev->dev, "OneNAND Sync. Burst Read enabled\n");

- err = mtd_device_parse_register(&info->mtd, NULL, 0,
+ err = mtd_device_parse_register(onenand->mtd, NULL, 0,
pdata ? pdata->parts : NULL,
pdata ? pdata->nr_parts : 0);

--
1.7.4.1

2011-06-17 17:10:47

by Brian Norris

Subject: Re: [PATCH 2/2] mtd: onenand/samsung.c: fix build error

Hi,

On Fri, Jun 17, 2011 at 1:11 AM, Axel Lin <[email protected]> wrote:
> - ? ? ? err = mtd_device_parse_register(&info->mtd, NULL, 0,
> + ? ? ? err = mtd_device_parse_register(onenand->mtd, NULL, 0,
> ? ? ? ? ? ? ? ? ? ? ? ?pdata ? pdata->parts : NULL,
> ? ? ? ? ? ? ? ? ? ? ? ?pdata ? pdata->nr_parts : 0);

Wouldn't it be just the same (and shorter) to use "mtd" instead of
onenand->mtd? Like:

err = mtd_device_parse_register(mtd, NULL, 0,
pdata ? pdata->parts : NULL,
pdata ? pdata->nr_parts : 0);

Brian

2011-06-22 05:07:00

by Artem Bityutskiy

Subject: Re: [PATCH 2/2] mtd: onenand/samsung.c: fix build error

On Fri, 2011-06-17 at 10:10 -0700, Brian Norris wrote:
> Hi,
>
> On Fri, Jun 17, 2011 at 1:11 AM, Axel Lin <[email protected]> wrote:
> > - err = mtd_device_parse_register(&info->mtd, NULL, 0,
> > + err = mtd_device_parse_register(onenand->mtd, NULL, 0,
> > pdata ? pdata->parts : NULL,
> > pdata ? pdata->nr_parts : 0);

Yeah, just did this, thanks.

--
Best Regards,
Artem Bityutskiy