2024-03-07 09:54:35

by Rick Wertenbroek

Subject: [PATCH] phy: rockchip: Fix typo in function names

Several functions had "rochchip" instead of "rockchip" in their name.
Replace "rochchip" by "rockchip".

Signed-off-By: Rick Wertenbroek <[email protected]>
---
drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 4 ++--
drivers/phy/rockchip/phy-rockchip-snps-pcie3.c | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
index 76b9cf417591..35d5c18661a3 100644
--- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
+++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
@@ -245,7 +245,7 @@ static int rockchip_combphy_exit(struct phy *phy)
return 0;
}

-static const struct phy_ops rochchip_combphy_ops = {
+static const struct phy_ops rockchip_combphy_ops = {
.init = rockchip_combphy_init,
.exit = rockchip_combphy_exit,
.owner = THIS_MODULE,
@@ -352,7 +352,7 @@ static int rockchip_combphy_probe(struct platform_device *pdev)
return ret;
}

- priv->phy = devm_phy_create(dev, NULL, &rochchip_combphy_ops);
+ priv->phy = devm_phy_create(dev, NULL, &rockchip_combphy_ops);
if (IS_ERR(priv->phy)) {
dev_err(dev, "failed to create combphy\n");
return PTR_ERR(priv->phy);
diff --git a/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c b/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c
index 121e5961ce11..3cdc7625b308 100644
--- a/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c
+++ b/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c
@@ -187,7 +187,7 @@ static const struct rockchip_p3phy_ops rk3588_ops = {
.phy_init = rockchip_p3phy_rk3588_init,
};

-static int rochchip_p3phy_init(struct phy *phy)
+static int rockchip_p3phy_init(struct phy *phy)
{
struct rockchip_p3phy_priv *priv = phy_get_drvdata(phy);
int ret;
@@ -210,7 +210,7 @@ static int rochchip_p3phy_init(struct phy *phy)
return ret;
}

-static int rochchip_p3phy_exit(struct phy *phy)
+static int rockchip_p3phy_exit(struct phy *phy)
{
struct rockchip_p3phy_priv *priv = phy_get_drvdata(phy);

@@ -219,9 +219,9 @@ static int rochchip_p3phy_exit(struct phy *phy)
return 0;
}

-static const struct phy_ops rochchip_p3phy_ops = {
- .init = rochchip_p3phy_init,
- .exit = rochchip_p3phy_exit,
+static const struct phy_ops rockchip_p3phy_ops = {
+ .init = rockchip_p3phy_init,
+ .exit = rockchip_p3phy_exit,
.set_mode = rockchip_p3phy_set_mode,
.owner = THIS_MODULE,
};
@@ -280,7 +280,7 @@ static int rockchip_p3phy_probe(struct platform_device *pdev)
return priv->num_lanes;
}

- priv->phy = devm_phy_create(dev, NULL, &rochchip_p3phy_ops);
+ priv->phy = devm_phy_create(dev, NULL, &rockchip_p3phy_ops);
if (IS_ERR(priv->phy)) {
dev_err(dev, "failed to create combphy\n");
return PTR_ERR(priv->phy);
--
2.25.1

2024-03-07 10:07:07

by Rick Wertenbroek

Subject: Re: [PATCH] phy: rockchip: Fix typo in function names

On Thu, Mar 7, 2024 at 10:54 AM Rick Wertenbroek
<[email protected]> wrote:
>
> Several functions had "rochchip" instead of "rockchip" in their name.
> Replace "rochchip" by "rockchip".
>
> Signed-off-By: Rick Wertenbroek <[email protected]>
> ---
> drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 4 ++--
> drivers/phy/rockchip/phy-rockchip-snps-pcie3.c | 12 ++++++------
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
> index 76b9cf417591..35d5c18661a3 100644
> --- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
> +++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
> @@ -245,7 +245,7 @@ static int rockchip_combphy_exit(struct phy *phy)
> return 0;
> }
>
> -static const struct phy_ops rochchip_combphy_ops = {
> +static const struct phy_ops rockchip_combphy_ops = {
> .init = rockchip_combphy_init,
> .exit = rockchip_combphy_exit,
> .owner = THIS_MODULE,
> @@ -352,7 +352,7 @@ static int rockchip_combphy_probe(struct platform_device *pdev)
> return ret;
> }
>
> - priv->phy = devm_phy_create(dev, NULL, &rochchip_combphy_ops);
> + priv->phy = devm_phy_create(dev, NULL, &rockchip_combphy_ops);
> if (IS_ERR(priv->phy)) {
> dev_err(dev, "failed to create combphy\n");
> return PTR_ERR(priv->phy);
> diff --git a/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c b/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c
> index 121e5961ce11..3cdc7625b308 100644
> --- a/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c
> +++ b/drivers/phy/rockchip/phy-rockchip-snps-pcie3.c
> @@ -187,7 +187,7 @@ static const struct rockchip_p3phy_ops rk3588_ops = {
> .phy_init = rockchip_p3phy_rk3588_init,
> };
>
> -static int rochchip_p3phy_init(struct phy *phy)
> +static int rockchip_p3phy_init(struct phy *phy)
> {
> struct rockchip_p3phy_priv *priv = phy_get_drvdata(phy);
> int ret;
> @@ -210,7 +210,7 @@ static int rochchip_p3phy_init(struct phy *phy)
> return ret;
> }
>
> -static int rochchip_p3phy_exit(struct phy *phy)
> +static int rockchip_p3phy_exit(struct phy *phy)
> {
> struct rockchip_p3phy_priv *priv = phy_get_drvdata(phy);
>
> @@ -219,9 +219,9 @@ static int rochchip_p3phy_exit(struct phy *phy)
> return 0;
> }
>
> -static const struct phy_ops rochchip_p3phy_ops = {
> - .init = rochchip_p3phy_init,
> - .exit = rochchip_p3phy_exit,
> +static const struct phy_ops rockchip_p3phy_ops = {
> + .init = rockchip_p3phy_init,
> + .exit = rockchip_p3phy_exit,
> .set_mode = rockchip_p3phy_set_mode,
> .owner = THIS_MODULE,
> };
> @@ -280,7 +280,7 @@ static int rockchip_p3phy_probe(struct platform_device *pdev)
> return priv->num_lanes;
> }
>
> - priv->phy = devm_phy_create(dev, NULL, &rochchip_p3phy_ops);
> + priv->phy = devm_phy_create(dev, NULL, &rockchip_p3phy_ops);
> if (IS_ERR(priv->phy)) {
> dev_err(dev, "failed to create combphy\n");
> return PTR_ERR(priv->phy);
> --
> 2.25.1
>

Compiled and tested on RK3588 boards (FriendlyElec NanoPC-T6, and CM3588).
"grep -rni rochchip ." inside the kernel folder to make sure no
occurrence was missed.

Best regards,
Rick

2024-03-07 10:31:29

by Heiko Stuebner

Subject: Re: [PATCH] phy: rockchip: Fix typo in function names

Am Donnerstag, 7. M?rz 2024, 10:53:18 CET schrieb Rick Wertenbroek:
> Several functions had "rochchip" instead of "rockchip" in their name.
> Replace "rochchip" by "rockchip".
>
> Signed-off-By: Rick Wertenbroek <[email protected]>

Reviewed-by: Heiko Stuebner <[email protected]>

2024-04-05 17:11:08

by Vinod Koul

Subject: Re: [PATCH] phy: rockchip: Fix typo in function names

On Thu, 07 Mar 2024 10:53:18 +0100, Rick Wertenbroek wrote:
> Several functions had "rochchip" instead of "rockchip" in their name.
> Replace "rochchip" by "rockchip".
>
>

Applied, thanks!

[1/1] phy: rockchip: Fix typo in function names
commit: 9b6bfad9070a95d19973be17177e5d9220cbbf1f

Best regards,
--
~Vinod