Hi all,
After merging the scsi-mkp tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:
drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_release':
drivers/scsi/lpfc/lpfc_debugfs.c:2109:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
2109 | vfree(debug->buffer);
| ^~~~~
| kvfree
drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_open':
drivers/scsi/lpfc/lpfc_debugfs.c:2150:18: error: implicit declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration]
2150 | debug->buffer = vmalloc(size);
| ^~~~~~~
| kvmalloc
drivers/scsi/lpfc/lpfc_debugfs.c:2150:16: warning: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
2150 | debug->buffer = vmalloc(size);
| ^
Caused by commit
95bfc6d8ad86 ("scsi: lpfc: Make FW logging dynamically configurable")
I have used the scsi-mkp tree from next-20191024 for today.
--
Cheers,
Stephen Rothwell
On 10/24/2019 8:07 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_release':
> drivers/scsi/lpfc/lpfc_debugfs.c:2109:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
> 2109 | vfree(debug->buffer);
> | ^~~~~
> | kvfree
> drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_open':
> drivers/scsi/lpfc/lpfc_debugfs.c:2150:18: error: implicit declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration]
> 2150 | debug->buffer = vmalloc(size);
> | ^~~~~~~
> | kvmalloc
> drivers/scsi/lpfc/lpfc_debugfs.c:2150:16: warning: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 2150 | debug->buffer = vmalloc(size);
> | ^
>
> Caused by commit
>
> 95bfc6d8ad86 ("scsi: lpfc: Make FW logging dynamically configurable")
>
> I have used the scsi-mkp tree from next-20191024 for today.
>
I will resolve this quickly...
-- james
Hi all,
On Fri, 25 Oct 2019 14:07:36 +1100 Stephen Rothwell <[email protected]> wrote:
>
> After merging the scsi-mkp tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_release':
> drivers/scsi/lpfc/lpfc_debugfs.c:2109:2: error: implicit declaration of function 'vfree'; did you mean 'kvfree'? [-Werror=implicit-function-declaration]
> 2109 | vfree(debug->buffer);
> | ^~~~~
> | kvfree
> drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_ras_log_open':
> drivers/scsi/lpfc/lpfc_debugfs.c:2150:18: error: implicit declaration of function 'vmalloc'; did you mean 'kvmalloc'? [-Werror=implicit-function-declaration]
> 2150 | debug->buffer = vmalloc(size);
> | ^~~~~~~
> | kvmalloc
> drivers/scsi/lpfc/lpfc_debugfs.c:2150:16: warning: assignment to 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 2150 | debug->buffer = vmalloc(size);
> | ^
>
> Caused by commit
>
> 95bfc6d8ad86 ("scsi: lpfc: Make FW logging dynamically configurable")
>
> I have used the scsi-mkp tree from next-20191024 for today.
This build failure now appears in the scsi tree build. I have applied the
fix from James Smart for today.
--
Cheers,
Stephen Rothwell
Stephen,
>> I have used the scsi-mkp tree from next-20191024 for today.
>
> This build failure now appears in the scsi tree build. I have applied
> the fix from James Smart for today.
Should be fixed in my for-next now.
--
Martin K. Petersen Oracle Linux Engineering
Hi Martin,
On Mon, 28 Oct 2019 22:28:03 -0400 "Martin K. Petersen" <[email protected]> wrote:
>
> >> I have used the scsi-mkp tree from next-20191024 for today.
> >
> > This build failure now appears in the scsi tree build. I have applied
> > the fix from James Smart for today.
>
> Should be fixed in my for-next now.
Thanks. I also see that James B has merged your tree, so its all good
now.
--
Cheers,
Stephen Rothwell