2012-02-03 07:03:33

by Cong Wang

[permalink] [raw]
Subject: [Patch] avr32: select GENERIC_ATOMIC64

avr32 doesn't implement atomic64_ operations, if not select this,
we would get:

kernel/trace/trace_clock.c:117: error: syntax error before 'trace_counter'
kernel/trace/trace_clock.c:126: error: implicit declaration of function 'atomic64_add_return'

Cc: Haavard Skinnemoen <[email protected]>
Cc: Hans-Christian Egtvedt <[email protected]>
Signed-off-by: WANG Cong <[email protected]>

---
diff --git a/arch/avr32/Kconfig b/arch/avr32/Kconfig
index 197e96f..6ecb8f4 100644
--- a/arch/avr32/Kconfig
+++ b/arch/avr32/Kconfig
@@ -11,6 +11,7 @@ config AVR32
select HARDIRQS_SW_RESEND
select GENERIC_IRQ_SHOW
select ARCH_HAVE_NMI_SAFE_CMPXCHG
+ select GENERIC_ATOMIC64
help
AVR32 is a high-performance 32-bit RISC microprocessor core,
designed for cost-sensitive embedded applications, with particular


Subject: Re: [Patch] avr32: select GENERIC_ATOMIC64

Around Fri 03 Feb 2012 15:03:00 +0800 or thereabout, Cong Wang wrote:
> avr32 doesn't implement atomic64_ operations, if not select this,
> we would get:
>
> kernel/trace/trace_clock.c:117: error: syntax error before 'trace_counter'
> kernel/trace/trace_clock.c:126: error: implicit declaration of function 'atomic64_add_return'
>
> Cc: Haavard Skinnemoen <[email protected]>
> Cc: Hans-Christian Egtvedt <[email protected]>
> Signed-off-by: WANG Cong <[email protected]>

Thanks Cong, but Fabio beat you to it; https://lkml.org/lkml/2012/2/2/406

The above patch (similar to yours), was just pulled into Andrews tree.

> ---
> diff --git a/arch/avr32/Kconfig b/arch/avr32/Kconfig
> index 197e96f..6ecb8f4 100644
> --- a/arch/avr32/Kconfig
> +++ b/arch/avr32/Kconfig
> @@ -11,6 +11,7 @@ config AVR32
> select HARDIRQS_SW_RESEND
> select GENERIC_IRQ_SHOW
> select ARCH_HAVE_NMI_SAFE_CMPXCHG
> + select GENERIC_ATOMIC64
> help
> AVR32 is a high-performance 32-bit RISC microprocessor core,
> designed for cost-sensitive embedded applications, with particular

--
mvh
Hans-Christian Egtvedt

2012-02-03 07:39:25

by Cong Wang

[permalink] [raw]
Subject: Re: [Patch] avr32: select GENERIC_ATOMIC64

On 02/03/2012 03:36 PM, Hans-Christian Egtvedt wrote:
> Around Fri 03 Feb 2012 15:03:00 +0800 or thereabout, Cong Wang wrote:
>> avr32 doesn't implement atomic64_ operations, if not select this,
>> we would get:
>>
>> kernel/trace/trace_clock.c:117: error: syntax error before 'trace_counter'
>> kernel/trace/trace_clock.c:126: error: implicit declaration of function 'atomic64_add_return'
>>
>> Cc: Haavard Skinnemoen<[email protected]>
>> Cc: Hans-Christian Egtvedt<[email protected]>
>> Signed-off-by: WANG Cong<[email protected]>
>
> Thanks Cong, but Fabio beat you to it; https://lkml.org/lkml/2012/2/2/406
>
> The above patch (similar to yours), was just pulled into Andrews tree.

Yeah, then ignore mine. :)

Thanks.