2012-02-04 09:56:48

by Jerry Snitselaar

Subject: [PATCH] Kbuild: Makefile: clean up samples directory

Playing around with make randconfig I ended up with CONFIG_SAMPLES
set. After cleaning up the build I noticed that git status was
showing samples/hidraw/hid-example as an untracked file.

Adding samples to clean-dirs seems to solve the problem, but
I don't know if that is the correct way to solve the issue.

Signed-off-by: Gerard Snitselaar <[email protected]>
---
Makefile | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index e3b23e8..0a83480 100644
--- a/Makefile
+++ b/Makefile
@@ -1170,7 +1170,7 @@ MRPROPER_FILES += .config .config.old .version .old_version \
#
clean: rm-dirs := $(CLEAN_DIRS)
clean: rm-files := $(CLEAN_FILES)
-clean-dirs := $(addprefix _clean_, . $(vmlinux-alldirs) Documentation)
+clean-dirs := $(addprefix _clean_, . $(vmlinux-alldirs) Documentation samples)

PHONY += $(clean-dirs) clean archclean
$(clean-dirs):
--
1.7.7.6

2012-02-25 00:17:59

by Michal Marek

Subject: Re: [PATCH] Kbuild: Makefile: clean up samples directory

On Sat, Feb 04, 2012 at 02:55:59AM -0700, Gerard Snitselaar wrote:
> Playing around with make randconfig I ended up with CONFIG_SAMPLES
> set. After cleaning up the build I noticed that git status was
> showing samples/hidraw/hid-example as an untracked file.
>
> Adding samples to clean-dirs seems to solve the problem, but
> I don't know if that is the correct way to solve the issue.

It is. I applied your patch to kbuild.git#kbuild now.

Michal