2012-02-14 19:31:13

by Bill Nottingham

[permalink] [raw]
Subject: [PATCH] Make 'Thermal Table has changed' a debug message.

If the recommended action is "do nothing", we shouldn't be cluttering
the logs with it.

Signed-off-by: Bill Nottingham <[email protected]>
---
drivers/platform/x86/thinkpad_acpi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index ea0c607..a96983e 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -3605,7 +3605,7 @@ static bool hotkey_notify_6xxx(const u32 hkey,

switch (hkey) {
case TP_HKEY_EV_THM_TABLE_CHANGED:
- pr_info("EC reports that Thermal Table has changed\n");
+ pr_debug("EC reports that Thermal Table has changed\n");
/* recommended action: do nothing, we don't have
* Lenovo ATM information */
return true;
--
1.7.7.6


Subject: Re: [ibm-acpi-devel] [PATCH] Make 'Thermal Table has changed' a debug message.

On Tue, 14 Feb 2012, Bill Nottingham wrote:
> If the recommended action is "do nothing", we shouldn't be cluttering
> the logs with it.
>
> Signed-off-by: Bill Nottingham <[email protected]>
Acked-by: Henrique de Moraes Holschuh <[email protected]>

We never figured out what interesting hint the thinkpad was trying to give
us.

> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index ea0c607..a96983e 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -3605,7 +3605,7 @@ static bool hotkey_notify_6xxx(const u32 hkey,
>
> switch (hkey) {
> case TP_HKEY_EV_THM_TABLE_CHANGED:
> - pr_info("EC reports that Thermal Table has changed\n");
> + pr_debug("EC reports that Thermal Table has changed\n");
> /* recommended action: do nothing, we don't have
> * Lenovo ATM information */
> return true;

--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh