2012-02-17 13:08:40

by Ajeet Yadav

Subject: [PATCH 1/2] ARM: dma-mapping: its array of pointer

To be consistant with declaration and usage of
consistent_pte it need to be an array of (pte *)

Signed-off-by: Ajeet Yadav <[email protected]>
---
arch/arm/mm/dma-mapping.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 1aa664a..04bfa76 100644
--- a/arch/arm/mm/dma-mapping.c
+++ b/arch/arm/mm/dma-mapping.c
@@ -170,7 +170,7 @@ static int __init consistent_init(void)
unsigned long base = consistent_base;
unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;

- consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL);
+ consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
if (!consistent_pte) {
pr_err("%s: no memory\n", __func__);
return -ENOMEM;
--
1.7.8.4

2012-02-18 16:09:40

by Tixy

Subject: Re: [PATCH 1/2] ARM: dma-mapping: its array of pointer

On Fri, 2012-02-17 at 18:39 +0530, Ajeet Yadav wrote:
> To be consistant with declaration and usage of
^^^^^^^^^^
Spelling mistake, should be 'consistent'

> consistent_pte it need to be an array of (pte *)
^^^^
Grammar mistake, should be 'needs'.

>
> Signed-off-by: Ajeet Yadav <[email protected]>

The title of this patch is a bit vague, perhaps something like:
"ARM: dma-mapping: Fix the type used for consistent_pte size
calculation"

The actual patch looks correct.

--
Tixy

> ---
> arch/arm/mm/dma-mapping.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index 1aa664a..04bfa76 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -170,7 +170,7 @@ static int __init consistent_init(void)
> unsigned long base = consistent_base;
> unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;
>
> - consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL);
> + consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
> if (!consistent_pte) {
> pr_err("%s: no memory\n", __func__);
> return -ENOMEM;

2012-02-22 03:36:50

by Ajeet Yadav

Subject: Re: [PATCH 1/2] ARM: dma-mapping: its array of pointer

thanks, reposted with changes.

Ajeet

On Sat, Feb 18, 2012 at 9:18 PM, Tixy <[email protected]> wrote:
> On Fri, 2012-02-17 at 18:39 +0530, Ajeet Yadav wrote:
>> To be consistant with declaration and usage of
>        ^^^^^^^^^^
> Spelling mistake, should be 'consistent'
>
>> consistent_pte it need to be an array of (pte *)
>                    ^^^^
> Grammar mistake, should be 'needs'.
>
>>
>> Signed-off-by: Ajeet Yadav <[email protected]>
>
> The title of this patch is a bit vague, perhaps something like:
> "ARM: dma-mapping: Fix the type used for consistent_pte size
> calculation"
>
> The actual patch looks correct.
>
> --
> Tixy
>
>> ---
>>  arch/arm/mm/dma-mapping.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
>> index 1aa664a..04bfa76 100644
>> --- a/arch/arm/mm/dma-mapping.c
>> +++ b/arch/arm/mm/dma-mapping.c
>> @@ -170,7 +170,7 @@ static int __init consistent_init(void)
>>       unsigned long base = consistent_base;
>>       unsigned long num_ptes = (CONSISTENT_END - base) >> PMD_SHIFT;
>>
>> -     consistent_pte = kmalloc(num_ptes * sizeof(pte_t), GFP_KERNEL);
>> +     consistent_pte = kmalloc(num_ptes * sizeof(pte_t *), GFP_KERNEL);
>>       if (!consistent_pte) {
>>               pr_err("%s: no memory\n", __func__);
>>               return -ENOMEM;
>
>
>