2012-02-22 13:07:00

by Davidlohr Bueso

Subject: [PATCH] tg3: remove IRQF_SAMPLE_RANDOM flag

From: Davidlohr Bueso <[email protected]>

This driver is the last user of the IRQF_SAMPLE_RANDOM flag for net drivers, and since add_*_randomness
interfaces have now deprecated the flag as a source of external noise, we can remove it.

Signed-off-by: Davidlohr Bueso <[email protected]>
---
drivers/net/ethernet/broadcom/tg3.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index a1f2e0f..2badfc3 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -9401,7 +9401,7 @@ static int tg3_test_interrupt(struct tg3 *tp)
}

err = request_irq(tnapi->irq_vec, tg3_test_isr,
- IRQF_SHARED | IRQF_SAMPLE_RANDOM, dev->name, tnapi);
+ IRQF_SHARED, dev->name, tnapi);
if (err)
return err;

--
1.7.4.1

2012-02-22 19:57:29

by David Miller

Subject: Re: [PATCH] tg3: remove IRQF_SAMPLE_RANDOM flag

From: Davidlohr Bueso <[email protected]>
Date: Wed, 22 Feb 2012 14:06:54 +0100

> From: Davidlohr Bueso <[email protected]>
>
> This driver is the last user of the IRQF_SAMPLE_RANDOM flag for net drivers, and since add_*_randomness
> interfaces have now deprecated the flag as a source of external noise, we can remove it.
>
> Signed-off-by: Davidlohr Bueso <[email protected]>

Applied.