2012-02-22 13:53:42

by Dimitris Papastamos

[permalink] [raw]

Subject: [PATCH] regmap: Append device name in the root debugfs dir

---

Signed-off-by: Dimitris Papastamos <[email protected]>
---
drivers/base/regmap/regmap-debugfs.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/base/regmap/regmap-debugfs.c b/drivers/base/regmap/regmap-debugfs.c
index b3b4b8f..f396246 100644
--- a/drivers/base/regmap/regmap-debugfs.c
+++ b/drivers/base/regmap/regmap-debugfs.c
@@ -179,8 +179,12 @@ static const struct file_operations regmap_access_fops = {

void regmap_debugfs_init(struct regmap *map)
{
- map->debugfs = debugfs_create_dir(dev_name(map->dev),
- regmap_debugfs_root);
+ char name[64];
+
+ snprintf(name, sizeof(name), "%s-%s",
+ dev_name(map->dev), map->dev->driver->name);
+
+ map->debugfs = debugfs_create_dir(name, regmap_debugfs_root);
if (!map->debugfs) {
dev_warn(map->dev, "Failed to create debugfs directory\n");
return;
--
1.7.9.1

2012-02-22 13:57:17

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH] regmap: Append device name in the root debugfs dir

---

On Wed, Feb 22, 2012 at 01:53:03PM +0000, Dimitris Papastamos wrote:

> void regmap_debugfs_init(struct regmap *map)
> {
> - map->debugfs = debugfs_create_dir(dev_name(map->dev),
> - regmap_debugfs_root);
> + char name[64];

That's a magic number, where did it come from?

> +
> + snprintf(name, sizeof(name), "%s-%s",
> + dev_name(map->dev), map->dev->driver->name);
> +
> + map->debugfs = debugfs_create_dir(name, regmap_debugfs_root);

No, keep the directory name the same and add a new file.

---

Attachments:

(No filename) (506.00 B)
signature.asc (836.00 B)
Digital signature Download all attachments

2012-02-22 14:00:54

by Dimitris Papastamos

[permalink] [raw]

Subject: Re: [PATCH] regmap: Append device name in the root debugfs dir

---

On Wed, Feb 22, 2012 at 01:57:09PM +0000, Mark Brown wrote:
> On Wed, Feb 22, 2012 at 01:53:03PM +0000, Dimitris Papastamos wrote:
>
> > void regmap_debugfs_init(struct regmap *map)
> > {
> > - map->debugfs = debugfs_create_dir(dev_name(map->dev),
> > - regmap_debugfs_root);
> > + char name[64];
>
> That's a magic number, where did it come from?

I can try to use something like NAME_MAX I suppose.

> > +
> > + snprintf(name, sizeof(name), "%s-%s",
> > + dev_name(map->dev), map->dev->driver->name);
> > +
> > + map->debugfs = debugfs_create_dir(name, regmap_debugfs_root);
>
> No, keep the directory name the same and add a new file.

Right, that was what I had initially implemented but seemed a bit of
overkill, but yea I can do that.

Thanks,
Dimitris