2012-02-23 02:03:55

by Nishanth Menon

Subject: [PATCH] MFD: TWL 6030: make twl6030_irq_set_wake static

twl6030_irq_set_wake is not used anywhere else in the kernel
except as irq_chip.irq_set_wake. No reason for it to be exported.

Also fixes build warning:
drivers/mfd/twl6030-irq.c:230:5: warning: symbol 'twl6030_irq_set_wake' was not declared. Should it be static?

Signed-off-by: Nishanth Menon <[email protected]>
---
drivers/mfd/twl6030-irq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c
index aa367a2..3c2cc00 100644
--- a/drivers/mfd/twl6030-irq.c
+++ b/drivers/mfd/twl6030-irq.c
@@ -236,7 +236,7 @@ static inline void activate_irq(int irq)
#endif
}

-int twl6030_irq_set_wake(struct irq_data *d, unsigned int on)
+static int twl6030_irq_set_wake(struct irq_data *d, unsigned int on)
{
if (on)
atomic_inc(&twl6030_wakeirqs);
--
1.7.5.4

2012-02-27 14:31:49

by Samuel Ortiz

Subject: Re: [PATCH] MFD: TWL 6030: make twl6030_irq_set_wake static

Hi Nishan,

On Wed, Feb 22, 2012 at 08:03:59PM -0600, Nishanth Menon wrote:
> twl6030_irq_set_wake is not used anywhere else in the kernel
> except as irq_chip.irq_set_wake. No reason for it to be exported.
>
> Also fixes build warning:
> drivers/mfd/twl6030-irq.c:230:5: warning: symbol 'twl6030_irq_set_wake' was not declared. Should it be static?
>
Applied as well, thanks.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/