2022-11-15 10:57:31

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: trim addresses to 8 digits

Hex numbers in addresses and sizes should be rather eight digits, not
nine. Drop leading zeros. No functional change (same DTB).

Suggested-by: Konrad Dybcio <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
index 552c0da3c479..49db223a0777 100644
--- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
@@ -2222,7 +2222,7 @@ compute-cb@3 {

cdsp: remoteproc@98900000 {
compatible = "qcom,sm8350-cdsp-pas";
- reg = <0 0x098900000 0 0x1400000>;
+ reg = <0 0x98900000 0 0x1400000>;

interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_LEVEL_HIGH>,
<&smp2p_cdsp_in 0 IRQ_TYPE_EDGE_RISING>,
diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 19a0f5033cc9..f20db5456765 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -2091,7 +2091,7 @@ compute-cb@3 {

remoteproc_adsp: remoteproc@30000000 {
compatible = "qcom,sm8450-adsp-pas";
- reg = <0 0x030000000 0 0x100>;
+ reg = <0 0x30000000 0 0x100>;

interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
<&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
@@ -2157,7 +2157,7 @@ compute-cb@5 {

remoteproc_cdsp: remoteproc@32300000 {
compatible = "qcom,sm8450-cdsp-pas";
- reg = <0 0x032300000 0 0x1400000>;
+ reg = <0 0x32300000 0 0x1400000>;

interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_EDGE_RISING>,
<&smp2p_cdsp_in 0 IRQ_TYPE_EDGE_RISING>,
--
2.34.1



2022-11-15 11:13:22

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: trim addresses to 8 digits



On 15/11/2022 11:50, Krzysztof Kozlowski wrote:
> Hex numbers in addresses and sizes should be rather eight digits, not
> nine. Drop leading zeros. No functional change (same DTB).
>
> Suggested-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sm8350.dtsi | 2 +-
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index 552c0da3c479..49db223a0777 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -2222,7 +2222,7 @@ compute-cb@3 {
>
> cdsp: remoteproc@98900000 {
> compatible = "qcom,sm8350-cdsp-pas";
> - reg = <0 0x098900000 0 0x1400000>;
> + reg = <0 0x98900000 0 0x1400000>;
>
> interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_LEVEL_HIGH>,
> <&smp2p_cdsp_in 0 IRQ_TYPE_EDGE_RISING>,
> diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> index 19a0f5033cc9..f20db5456765 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
> @@ -2091,7 +2091,7 @@ compute-cb@3 {
>
> remoteproc_adsp: remoteproc@30000000 {
> compatible = "qcom,sm8450-adsp-pas";
> - reg = <0 0x030000000 0 0x100>;
> + reg = <0 0x30000000 0 0x100>;
>
> interrupts-extended = <&pdc 6 IRQ_TYPE_EDGE_RISING>,
> <&smp2p_adsp_in 0 IRQ_TYPE_EDGE_RISING>,
> @@ -2157,7 +2157,7 @@ compute-cb@5 {
>
> remoteproc_cdsp: remoteproc@32300000 {
> compatible = "qcom,sm8450-cdsp-pas";
> - reg = <0 0x032300000 0 0x1400000>;
> + reg = <0 0x32300000 0 0x1400000>;
>
> interrupts-extended = <&intc GIC_SPI 578 IRQ_TYPE_EDGE_RISING>,
> <&smp2p_cdsp_in 0 IRQ_TYPE_EDGE_RISING>,

2022-11-15 19:03:59

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: trim addresses to 8 digits

On Tue, 15 Nov 2022 11:50:46 +0100, Krzysztof Kozlowski wrote:
> Hex numbers in addresses and sizes should be rather eight digits, not
> nine. Drop leading zeros. No functional change (same DTB).
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: trim addresses to 8 digits
commit: 22dbcfd6f4a9f7d4391f0aa66d3f46addea4bee9

Best regards,
--
Bjorn Andersson <[email protected]>